[codex] Fix windows CI worktree path assertion#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a Windows CI failure in windows-latest by updating a unit test to compare normalized (canonical) paths rather than a Unix-style literal string, ensuring cross-platform path assertions remain stable.
Changes:
- Normalize
MainWorktreePathand expected path usingPath.GetFullPath(...)in the linked-worktree snapshot test.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes the current
windows-latestCI failure by making the linked-worktree path assertion compare canonical paths instead of a Unix-shaped literal.Why
The test used
"/repo"as the expected string. On Windows, the same rooted path normalizes differently, so the test failed even though the underlying worktree resolution logic was correct.Validation
dotnet test tests/SharpClaw.Code.UnitTests/SharpClaw.Code.UnitTests.csproj --no-restore --filter "FullyQualifiedName~GitWorkspaceService_should_detect_linked_worktree_main_path"dotnet test SharpClawCode.sln --no-restore