Skip to content

refactor(ui): Implement new icon set#8319

Open
alexcarpenter wants to merge 12 commits intomainfrom
carp/icon-improvements
Open

refactor(ui): Implement new icon set#8319
alexcarpenter wants to merge 12 commits intomainfrom
carp/icon-improvements

Conversation

@alexcarpenter
Copy link
Copy Markdown
Member

@alexcarpenter alexcarpenter commented Apr 15, 2026

Description

Migrate to new icon set https://www.figma.com/design/bTar3y0gIglvIxhmZsfHsj/Clerk-Mosaic?node-id=71-567&p=f&m=dev

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 17, 2026 3:02pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: bc8434a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/ui Minor
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter marked this pull request as ready for review April 15, 2026 17:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: fa718754-65d7-4d31-bd28-98fee46ac877

📥 Commits

Reviewing files that changed from the base of the PR and between 832fdec and bc8434a.

📒 Files selected for processing (3)
  • packages/ui/src/common/CreateOrganizationAction.tsx
  • packages/ui/src/components/OAuthConsent/OrgSelect.tsx
  • packages/ui/src/elements/Drawer.tsx
✅ Files skipped from review due to trivial changes (1)
  • packages/ui/src/components/OAuthConsent/OrgSelect.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/ui/src/common/CreateOrganizationAction.tsx

📝 Walkthrough

Walkthrough

This PR migrates the icon set across the @clerk/ui package: it updates many component icon imports/usages to new symbol names (e.g., Add → Plus, Check → Checkmark, Upload → ArrowUpTray), remaps numerous exports in packages/ui/src/icons/index.ts to different exported names and SVG bindings, adjusts a few icon sizing/spacing values, and relaxes CreateOrganizationAction props to accept an optional icon. A new changeset marks this as a minor release. No other component logic, control flow, or public API signatures (aside from the added optional icon prop) were changed.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: implementing a new icon set across the UI codebase, which aligns with all the file-level changes shown in the summary.
Description check ✅ Passed The description is directly related to the changeset, referencing a migration to a new icon set per a Figma design file, which matches the comprehensive icon replacements across 44+ files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread packages/ui/src/icons/index.ts Outdated
export { default as ApplePay } from './apple-pay.svg';
export { default as ArrowLeftIcon } from './arrow-left.svg';
export { default as ArrowRightButtonIcon } from './arrow-right-button.svg';
export { default as ArrowRightButtonIcon } from './triangle-right.svg';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add exports for the new names so that it's easier to correlate them between the SDK and Figma? For example, I assume Figma will list the icon as triangle-right, so we'd be expecting to use the TriangleRight icon. I think keeping the older name is fine for now (we'll want to clean them up later though).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thats a good callout 👍🏼 will get that update.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 16, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8319

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8319

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8319

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8319

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8319

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8319

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8319

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8319

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8319

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8319

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8319

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8319

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8319

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8319

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8319

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8319

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8319

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8319

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8319

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8319

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8319

commit: bc8434a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants