fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417jacekradko merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9a09c53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis pull request updates the dependency constraint for Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Summary
@tanstack/query-corefrom an exact pin (5.90.16) to^5.90.16in@clerk/sharedand@clerk/clerk-js@tanstack/react-queryversions, which pinquery-coreto their exact same patch versionMotivation
Vite's
resolve.deduperesolves modules from the project root'snode_modules/only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whosereact-queryresolved to a differentquery-corepatch (e.g.5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve@tanstack/query-coreand the app crashed.This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest
react-query@5.x, which pulled aquery-corethat didn't satisfy our exact5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.Test plan
saveTextLockfile = false) resolves@tanstack/query-corecleanly under Viteresolve.dedupe