fix(shared,clerk-js): raise @tanstack/query-core floor to ^5.100.6#8432
fix(shared,clerk-js): raise @tanstack/query-core floor to ^5.100.6#8432jacekradko merged 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 13245fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR raises the required Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Review rate limit: 4/5 reviews remaining, refill in 12 minutes. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
I can confirm it appears to be fixed now. thank you |
Summary
@tanstack/query-corefloor from^5.90.16to^5.100.6in@clerk/sharedand@clerk/clerk-jsquery-core@5.100.6into the lockfile so the CDN-publishedclerk-jsbundle embeds it (verified:isFetchednow ships inquery-core-vendors_clerk.browser_*.js)Why
@clerk/sharedand the productionclerk-jsCDN bundle share an implicit cross-bundle contract: shared constructsQueryObserverinstances againstQueryobjects from clerk-js'sQueryClient. After #8417 loosened the pin, consumer-side@clerk/sharedresolvedquery-coreto5.100.x(which addsQuery.isFetched()and has the Observer call it), while the CDN bundle still embedded5.90.16. The Observer then crashed callingisFetched()on the olderQueryobjects.Fixes #8428.
Raising the floor keeps consumer dedupe working with
^5.100.6(so #8417's Vite/Bun repro should still resolve) and ensures the CDN bundle used for this release embeds the samequery-coreversion that triggered the reporter's crash. The class of bug is structural — the cross-bundle contract onquery-coreshouldn't exist — and a follow-up will moveQueryClientownership into@clerk/sharedto eliminate it. This PR is the patch.Test plan
pnpm --filter @clerk/shared test -- --run(1069/1069 pass)pnpm --filter @clerk/clerk-js buildsucceeds andquery-core-vendors_*.jschunk containsisFetched5.100.6QueryObserver+5.90.16QueryClientreproducesquery.isFetched is not a function;5.100.6observer/client succeeds5.100.x) — should still resolve cleanly