Split test_all_templates into individual smoketests - #5645
Conversation
bf65804 to
932b84d
Compare
gefjon
left a comment
There was a problem hiding this comment.
I haven't carefully validated that the new precompiled modules match the old inline definitions, so hopefully you haven't committed any copy-paste errors. Otherwise, looks good. It seems like we shouldn't have the interface that allows constructing a smoketest using a non-precompiled module; what's blocking us from removing that entirely?
There are smoketests that are specifically testing module compilation. cc @gefjon |
Surely that could be accomplished by explicitly calling |
932b84d to
41d6a72
Compare
Description of Changes
This is part of the work to break up #5612 into smaller reviewable chunks.
During development and testing of #5612 (sharding the smoketest), I noticed that one shard consistently took longer to execute. This turned out to be whatever shard
test_all_templateswas assigned to. So this patch splitstest_all_templatesinto 24 individual smoketests so that they can all be distributed evenly among shards.In addition, I discovered there were quite a few rust modules that weren't being pre-compiled at all, so I've fixed that as well.
API and ABI breaking changes
None
Expected complexity level and risk
3 - A lot of AI assisted code motion. Mostly mechanical, but a large diff nonetheless.
Testing
All of the tests should continue to pass.