[miniflare] Update sending.mdx to account for new email logging location.#31970
Open
tpmmorris wants to merge 4 commits into
Open
[miniflare] Update sending.mdx to account for new email logging location.#31970tpmmorris wants to merge 4 commits into
tpmmorris wants to merge 4 commits into
Conversation
Added new location (.wrangler/tmp/email/...) for email logging to the local testing example output.
Contributor
Review✅ No issues found in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Merged
5 tasks
Reflect logging used in Miniflare to specify the system or project temporary directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new location (.wrangler/tmp/email/...) for email logging to the local testing example output.
Summary
Email logging was in an inconvenient location so an additional location has been added in .wrangler/tmp/email/<session-uuid>/email-text/<message-uuid>. When emails are sent by a worker, this new location is logged after 'Text (local)' and this change should be reflected in the documentation. Changelog entry added to src/content/email-service/.
Documentation checklist