docs(bots): warn that blocking /cdn-cgi paths degrades JS Detection#31976
Open
zeinjaber wants to merge 1 commit into
Open
docs(bots): warn that blocking /cdn-cgi paths degrades JS Detection#31976zeinjaber wants to merge 1 commit into
zeinjaber wants to merge 1 commit into
Conversation
Contributor
Review💡 1 suggestion found in commit Fix in your agentFix the following review findings in PR #31976 (https://github.com/cloudflare/cloudflare-docs/pull/31976).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Style Guide Review
### Suggestions (1)
#### SG-65b977d4c270 · Passive voice
- **File:** `src/content/docs/cloudflare-challenges/challenge-types/javascript-detections.mdx` line 180
- **Issue:** Line uses passive voice: 'No error is surfaced to the visitor'
- **Fix:** Rewrite in active voice, e.g. 'Cloudflare does not surface an error to the visitor.'
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewSuggestions (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a warning callout under the Limitations section of the JavaScript Detections page explaining that blocking
/cdn-cgi/challenge-platform/or/cdn-cgi/rumsilently degrades JS Detection accuracy.Why
Customers who apply broad WAF or firewall rules matching
/cdn-cgi/paths can inadvertently prevent the JavaScript Detections script from executing. When this happens,cf.bot_management.js_detection.passedreturnsfalsefor all affected requests with no visible error to the visitor, leading to unexpected bot score behavior and misfire of enforcement rules.Files changed
src/content/docs/cloudflare-challenges/challenge-types/javascript-detections.mdx— new### If you block /cdn-cgi/ pathssection with a caution calloutHow to verify
Navigate to /cloudflare-challenges/challenge-types/javascript-detections/ and confirm the new caution block appears at the bottom of the Limitations section.
Closes DEE-3693