Warn that .dev.vars.example entries become deployed secrets (Deploy button)#31989
Draft
ddyy wants to merge 1 commit into
Draft
Warn that .dev.vars.example entries become deployed secrets (Deploy button)#31989ddyy wants to merge 1 commit into
ddyy wants to merge 1 commit into
Conversation
Add a caution callout to the Deploy to Cloudflare button docs noting that every uncommented entry in .dev.vars.example is prompted as a required secret and stored on the deployed Worker. Because the file is conventionally a local-dev template that developers copy and edit, authors can unknowingly ship dev-only values (auth-bypass flags, localhost URLs, placeholders) to production. Closes cloudflare#31988.
ddyy
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque,
korinne and
vy-ton
as code owners
July 10, 2026 02:01
Contributor
Review✅ No issues found in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewNo style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
github-actions
Bot
assigned
GregBrimble,
irvinebroque,
korinne,
MattieTK,
vy-ton and
WalshyDev
Member
|
We're going to look at fixing this in the button itself rather than documenting it (as that's something few people will look to cc @chythram05 |
MattieTK
marked this pull request as draft
July 21, 2026 08:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a caution callout to the Deploy to Cloudflare buttons page, in the "Worker environment variables and secrets" section, warning that every uncommented entry in
.dev.vars.example(or.env.example) is presented as a required secret during deployment and stored on the deployed Worker.The page documents that secrets come from
.dev.vars.example, but not the consequence. That file is conventionally a local-development template. Nothing reads it directly; developers copy it to a gitignored.dev.varsand edit the copy. So authors pre-fill it with dev-friendly values and can unknowingly ship them to production. In my case this deployed an auth-bypass flag andlocalhostURLs to every one-click deployment of my app. Writeup: https://daniel-yang.com/writing/cloudflare-deploy-button-disabled-auth/Closes #31988.
Documentation checklist
Changelog entry— N/A (documentation clarification, not a product change)Redirects— N/A (no files renamed or moved)