Fix/model pages port#32009
Merged
Merged
Conversation
Contributor
Review
Fix in your agentFix the following review findings in PR #32009 (https://github.com/cloudflare/cloudflare-docs/pull/32009).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Code Review
### Warnings (3)
#### CR-b3d1cff18de6 · Badly indented admonition close marker
- **File:** `src/content/docs/durable-objects/reference/durable-objects-migrations.mdx` line 409
- **Issue:** The closing `:::` marker is indented with two spaces while the matching opener `:::caution[Important]` is flush left. MDX/remark admonition parsers treat an indented close fence as content rather than the actual end of the admonition, so the caution block will continue and can consume the following `:::note` block and paragraphs.
- **Fix:** Remove the leading spaces on the `:::` line so it aligns with the `:::caution[Important]` opener and correctly closes the admonition.
#### CR-6e2ae6cd81c0 · Sync effect runs before hydration is complete
- **File:** `src/nimbus/components/models/ModelFilters.tsx` line 356
- **Issue:** The URL-sync effect guards on `initializedRef.current`, but the init effect sets it to `true` before this effect runs in the same commit. On first mount the sync effect therefore executes while `search` and `selected` still hold their initial empty values, calling `relayout` with no filters and `setSearchParams({})`, which briefly clears the URL and reflows the grid to the unfiltered total before the state updates from hydration flush.
- **Fix:** Use a `hydrated` state variable instead of a ref (and include it in the sync effect dependencies), or initialize the search/selected state directly from the URL so the sync effect does not need an init guard.
#### CR-1e566b5b3e76 · Missing top border regression
- **File:** `src/nimbus/components/Footer.astro` line 108
- **Issue:** Line 108 changed `<footer class:list={["border-t border-border", className]}>` to `<footer class:list={[className]}>`, dropping the "border-t border-border" classes from the footer element. BaseLayout renders `<Footer />` and DocsLayout renders `<Footer ... />` without adding a border, so this removes the visual separator above the footer on every page.
- **Fix:** Restore "border-t border-border" in the footer class:list (e.g. `["border-t border-border", className]`) unless the removal was intentional.
### Suggestions (1)
#### CR-e4e16beab017 · Input schema omits demonstrated fields
- **File:** `src/content/catalog-models/anthropic-claude-sonnet-5.json` line 129
- **Issue:** The 'Creative Writing with High Effort' example at lines 129-134 sets `output_config.effort` and `thinking.type`, but `schema.input.properties` (lines 441-525) only defines `messages`, `max_tokens`, `system`, `stream`, and `metadata`, with no declarations for `output_config` or `thinking`.
- **Fix:** Add `output_config` and `thinking` property schemas under `schema.input.properties` so the documented schema matches the supported request fields used in the examples.
---
## Style Guide Review
### Suggestions (6)
#### SG-fb362e3bec2d · Heading uses title case
- **File:** `src/content/docs/r2/data-catalog/manage-catalogs.mdx` line 282
- **Issue:** #### Example read-write Access Policy
- **Fix:** Use sentence case: `#### Example read-write access policy`.
#### SG-3bcef4381d5c · Heading uses title case
- **File:** `src/content/docs/r2/data-catalog/manage-catalogs.mdx` line 309
- **Issue:** #### Example read-only Access Policy
- **Fix:** Use sentence case: `#### Example read-only access policy`.
#### SG-8579b8eaaaa1 · Use TypeScriptExample component for TS code blocks
- **File:** `src/content/docs/workflows/build/workers-api.mdx` line 714
- **Issue:** Line adds a raw ` ```ts ` fenced block in a docs MDX file.
- **Fix:** Use `<TypeScriptExample>` instead so a JS tab is auto-generated.
#### SG-780ee5a5a7a0 · Remove LLM-filler phrase
- **File:** `src/content/changelog/r2/2026-07-09-r2-data-catalog-read-only-tokens.mdx` line 18
- **Issue:** Line begins with `Note that`
- **Fix:** Remove `Note that` and state the fact directly: `Credentials vended by the catalog inherit the R2 storage permissions of the token used to authenticate.`
#### SG-c5987cce2bde · Bullet list has fewer than three items
- **File:** `src/content/changelog/r2/2026-07-09-r2-data-catalog-read-only-tokens.mdx` line 13
- **Issue:** List contains only two bullet items (read-only and write operations)
- **Fix:** Consider rewriting the two items as prose instead of a bullet list.
#### SG-89650ecc10b2 · Use TypeScriptExample component for TypeScript samples
- **File:** `src/content/docs/workflows/build/trigger-workflows.mdx` line 225
- **Issue:** Added a raw ```ts fenced block in a docs MDX file
- **Fix:** Replace the raw ```ts block with the <TypeScriptExample> component so JS is auto-generated.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (3)
Suggestions (1)
ConventionsNo convention issues found. Style Guide ReviewSuggestions (6)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
kodster28
approved these changes
Jul 10, 2026
Contributor
|
Preview URL: https://2bf491a5.preview.developers.cloudflare.com |
Contributor
Author
|
/bonk my PR is out of date, do you mind merging with production por favor? |
Contributor
|
✅ Merged the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the Nimbus AI model catalog (/ai/models, /workers-ai/models) and the shared page-actions row to parity with the production Starlight site, and stages the Nimbus markdown surface for Cloudflare's edge Markdown for Agents (removing the interim build-time .md routes, mirroring prod's PR #28921). Also aligns the docs footer with the content column.
Net: 660 insertions / 737 deletions across 13 files — mostly replacing bespoke Nimbus scaffolding with prod-shaped equivalents.
Changes
Details
controller it replaces.Verification
Deployment dependency (reviewer note)
Copy / View / index.md are edge-served. They work automatically when Nimbus becomes the origin behind developers.cloudflare.com/* (the zone already has Markdown for Agents + the /index.md URL rules zone-wide). They will not work on the current *.workers.dev preview, which isn't a zone. This is intentional, not a regression.
Screenshots (optional)
Documentation checklist