Skip to content

fix: close leaked file handles in config and token key loading #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fereidani wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −0
Open

fix: close leaked file handles in config and token key loading #1680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192e38f
fix: close key file after reading in Encrypter.fetchKey
fereidani Jun 24, 2026
6221f20
fix: close config file after strict reparse
fereidani Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ func ReadConfigFile(c *cli.Context, log *zerolog.Logger) (settings *configFileSe

// Parse it again, with strict mode, to find warnings.
if file, err := os.Open(configFile); err == nil {
defer func() { _ = file.Close() }()
decoder := yaml.NewDecoder(file)
decoder.KnownFields(true)
var unusedConfig configFileSettings
Expand Down
1 change: 1 addition & 0 deletions token/encrypt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ func (e *Encrypter) fetchKey(filename string) (*[32]byte, error) {
if err != nil {
return nil, err
}
defer func() { _ = f.Close() }()
buf := new(bytes.Buffer)
io.Copy(buf, f)

Expand Down