Add resolute test jobs - #522
Merged
Merged
Conversation
WalkthroughAdded Ubuntu Resolute stemcell resources, release-compilation jobs, stemcell-update jobs, and GCP, Warden, and Docker test jobs. Added a complete NATS deployment manifest. Updated Docker, GCP, and Warden test tasks to use NATS instead of Zookeeper. The GCP task now installs the DNS runtime configuration. Removed the integration-test script. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/pipeline.yml`:
- Around line 235-255: Add paused: true to the test-resolute-warden pipeline job
definition so Concourse does not schedule this known-failing Resolute test job
while preserving the existing plan and configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d1ef4258-da87-45a5-ae3e-9edcea49b6ba
📒 Files selected for processing (1)
ci/pipeline.yml
github-project-automation
Bot
moved this from Inbox
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
Add test-resolute-gcp, test-resolute-warden and test-resolute-docker as clones of the noble test jobs, differing only in the stemcell resource and the DIRECTOR_OPS_FILES / STEMCELL_OS params introduced earlier. For GCP, DIRECTOR_OPS_FILES goes on the bbl-up step, where it drives generation of the create/delete-director override scripts and the bbl ops drift guard; STEMCELL_OS goes on test-gcp, which only uploads the stemcell and deploys zookeeper. The warden and docker jobs stand up the director and deploy in a single task, so both params go on that step. In every case misc/use-compiled-resolute-releases.yml is applied last. Resolute is early in its release series, so these jobs ship without passed: constraints and are deliberately left out of promote, which still gates on test-smoke and the three noble jobs only.
zookeeper-release is unsupported. Add ci/assets/nats.yml, a minimal TLS-only nats deployment modeled on cf-deployment, and point the docker, gcp, and warden test tasks at it. test-gcp.sh also re-applies runtime-configs/dns.yml under bbl's "dns" runtime config name. bbl builds that config from a vendored bosh-deployment predating ubuntu-resolute, so bosh-dns went uninstalled and the deployment's DNS aliases would not resolve. Drop tests/run.sh: unreferenced since 2021, requires local VirtualBox, superseded by virtualbox/create-env.sh and the CI test tasks.
mkocher
force-pushed
the
add-resolute-test-jobs
branch
from
August 11, 2026 02:42
bca311f to
4593b6b
Compare
github-project-automation
Bot
moved this from Waiting for Changes | Open for Contribution
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/tasks/test-docker.sh`:
- Around line 36-46: Update the cleanup sequence in ci/tasks/test-docker.sh
lines 36-46 and ci/tasks/test-warden.sh lines 33-43: after recreating the nats
deployment, run bosh -n -d nats delete-deployment, then run the global bosh -n
clean-up --all command instead of cleaning up while the deployment remains
active.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 11db4c67-5684-403a-9f76-a9645da2904b
📒 Files selected for processing (5)
ci/assets/nats.ymlci/tasks/test-docker.shci/tasks/test-gcp.shci/tasks/test-warden.shtests/run.sh
💤 Files with no reviewable changes (1)
- tests/run.sh
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Waiting for Changes | Open for Contribution
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
ystros
approved these changes
Aug 11, 2026
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test-resolute-gcp, test-resolute-warden and test-resolute-docker as clones of the noble test jobs, differing only in the stemcell resource and the DIRECTOR_OPS_FILES / STEMCELL_OS params introduced earlier.
These jobs ship without passed: constraints and are deliberately left out of promote for now. Garden does not yet compile on Resolute, so the warden job will be paused for now.
These have been flown and are starting to run now.