Add ADR 0015: switch to factory_bot; supersede ADR 0002#5120
Open
philippthun wants to merge 1 commit into
Open
Add ADR 0015: switch to factory_bot; supersede ADR 0002#5120philippthun wants to merge 1 commit into
philippthun wants to merge 1 commit into
Conversation
ADR 0002 (2019) chose to keep machinist after a partial factory_bot migration hit friction with Sequel's mutual-foreign-key pattern. The blocker described there is solvable in factory_bot using a global to_create with save+refresh and after(:create) callbacks with transient flags. machinist 1.0.6 has had no upstream activity since 2013, and 2.0 is not a viable upgrade (no Sequel adapter, no Sham, non-persisting make). Mark ADR 0002 as superseded and add ADR 0015 documenting the new decision and the patterns that made it work.
Member
Author
|
Actual migration in #5121. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR 0002 (2019) chose to keep
machinistafter a partialfactory_botmigration hit friction with Sequel's mutual-foreign-key pattern.The blocker described there is solvable in
factory_botusing a globalto_createwithsave+refreshandafter(:create)callbacks with transient flags. machinist 1.0.6 has had no upstream activity since 2013, and 2.0 is not a viable upgrade (no Sequel adapter, no Sham, non-persisting make).Mark ADR 0002 as superseded and add ADR 0015 documenting the new decision and the patterns that made it work.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests