Repository navigation
chore(deps): drop jose fork via CLI v8 head - #6000
Merged
norman-abramovitz merged 3 commits intoOct 13, 2026
Merged
norman-abramovitz merged 3 commits into
norman-abramovitz merged 3 commits into
Conversation
Go 1.27.2 writes compiler export data version 5, which 2.13.1 cannot decode, so typecheck fails on fmt in src/jetstream and the gate stops there. go.mod still targets 1.27.1, so the version stamp matched and nothing rebuilt the linter. 2.14.0 reads the new format.
SermoDigital/jose panics at init under Go 1.27, so both modules replaced it with the norman-abramovitz/fw-jose fork. CLI v8 now uses golang-jwt v5 (cloudfoundry/cli#3872, merged on v8, untagged), so pin the v8 head as a pseudo-version and drop both replaces. Swap in the release tag once v8 is tagged. The move also brings grpc 1.84.0 and small indirect bumps. All seven modules are tidied; none references jose any more.
Record the move off SermoDigital/jose and the fw-jose fork, the dependency versions the CLI v8 head brings, and the golangci-lint bump that Go 1.27.2 needs.
norman-abramovitz
approved these changes
Oct 13, 2026
norman-abramovitz
left a comment
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM CF CLI has updated its dependencies about JWT usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
github.com/SermoDigital/josedependency and thenorman-abramovitz/fw-josefork that replaced it.SermoDigital/jose registers hash id 0 in an
init, which Go 1.27 rejects with a panic beforemain. It reached jetstream only throughcode.cloudfoundry.org/cli/v8/actor/v7action, used by cfapppush for app push, so both modules carried areplaceto a patched fork. cloudfoundry/cli#3872 moved the CLI togolang-jwtv5 and is merged on thev8branch, but no release has been tagged since v8.19.0.code.cloudfoundry.org/cli/v8to the currentv8head as a pseudo-version (v8.19.1-0.20261006035801-8f3eae3b52da) and drops bothreplacelines. The pseudo-version should give way to the release tag once v8 is tagged.make check lintandmake check gatefailed in typecheck on any machine with Go 1.27.2. go.mod still targets 1.27.1, so the Makefile's version stamp matched and never rebuilt the linter.changelog.d/0006-cli-golang-jwt.md.Checks
make check gate: frontend 3769 passed, production build, golangci-lint 0 issues across all seven modules, every module's Go tests pass, including cfapppush and the root jetstream package, whose test binaries link the CLI push code that used to pull in jose.make changelogreports no uncovered bumps;make previewassembles the fragment.AI disclosure (RFC-0047): prepared with AI coding assistance; reviewed by the author.