Skip to content

fix(vue): guard htmlLayerInstance in onUpdated/onUnmounted hooks #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strausr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vue): guard htmlLayerInstance in onUpdated/onUnmounted hooks #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vue/src/components/AdvancedImage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
cldImg: CloudinaryImage;
plugins?: Plugins;

[x: string]: any;

Check warning on line 125 in packages/vue/src/components/AdvancedImage.vue

View workflow job for this annotation

GitHub Actions / build (16) 

Unexpected any. Specify a different type

Check warning on line 125 in packages/vue/src/components/AdvancedImage.vue

View workflow job for this annotation

GitHub Actions / build (14) 

Unexpected any. Specify a different type

Check warning on line 125 in packages/vue/src/components/AdvancedImage.vue

View workflow job for this annotation

GitHub Actions / build (18) 

Unexpected any. Specify a different type
}

// Disabled linting due to [@vue/compiler-sfc] `defineProps` is a compiler macro and no longer needs to be imported.
Expand Down Expand Up @@ -152,6 +152,7 @@
* cloudinaryImage and the state of plugins.
*/
onUpdated(() => {
if (!htmlLayerInstance) return;
cancelCurrentlyRunningPlugins(htmlLayerInstance.htmlPluginState);
// call html layer to update the dom again with plugins and reset toBeCanceled
htmlLayerInstance.update(props.cldImg, props.plugins, SDKAnalyticsConstants);
Expand All @@ -161,7 +162,7 @@
* On unmount, we cancel the currently running plugins.
*/
onUnmounted(() => {
// Safely cancel running events on unmount.
if (!htmlLayerInstance) return;
cancelCurrentlyRunningPlugins(htmlLayerInstance.htmlPluginState);
});
</script>
3 changes: 2 additions & 1 deletion packages/vue/src/components/AdvancedVideo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
cldPoster?: VideoPoster;
useFetchFormat?: boolean;

[x: string]: any;

Check warning on line 36 in packages/vue/src/components/AdvancedVideo.vue

View workflow job for this annotation

GitHub Actions / build (16) 

Unexpected any. Specify a different type

Check warning on line 36 in packages/vue/src/components/AdvancedVideo.vue

View workflow job for this annotation

GitHub Actions / build (14) 

Unexpected any. Specify a different type

Check warning on line 36 in packages/vue/src/components/AdvancedVideo.vue

View workflow job for this annotation

GitHub Actions / build (18) 

Unexpected any. Specify a different type
}

// Disabled linting due to [@vue/compiler-sfc] `defineProps` is a compiler macro and no longer needs to be imported.
Expand Down Expand Up @@ -64,6 +64,7 @@
* cloudinaryVideo and the state of plugins.
*/
onUpdated(() => {
if (!htmlLayerInstance) return;
cancelCurrentlyRunningPlugins(htmlLayerInstance.htmlPluginState);
// call html layer to update the dom again with plugins and reset toBeCanceled
htmlLayerInstance.update(
Expand All @@ -79,7 +80,7 @@
* On unmount, we cancel the currently running plugins.
*/
onUnmounted(() => {
// Safely cancel running events on unmount.
if (!htmlLayerInstance) return;
cancelCurrentlyRunningPlugins(htmlLayerInstance.htmlPluginState);
});
</script>
Loading