chore: Make the font-weight themeable for display large text#4448
chore: Make the font-weight themeable for display large text#4448
Conversation
b7a8da0 to
d5f0d9f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4448 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 933 933
Lines 29409 29409
Branches 10661 10660 -1
=======================================
Hits 28645 28645
- Misses 716 757 +41
+ Partials 48 7 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a2cf630 to
d9b1bfe
Compare
| fontWeightHeadingM: '700', | ||
| fontWeightHeadingS: '700', | ||
| fontWeightHeadingXs: '700', | ||
| fontWeightDisplayLBold: '700', |
There was a problem hiding this comment.
Why do we add Bold to the token name? This suggests I should not set it to some other value than 700.
There was a problem hiding this comment.
Good call. I will just simply remove "Bold"
| } | ||
| &.value-large-variant { | ||
| @include styles.font-display-l; | ||
| font-weight: awsui.$font-box-value-large-weight; |
There was a problem hiding this comment.
Did you run this through the pipeline? I am unsure if this will cause a regression.
There was a problem hiding this comment.
Actually, I think it's ok - but still :)
There was a problem hiding this comment.
Since this change is narrowly scoped—only affecting box and link components when variant="awsui-value-large"—it may not be necessary to run it through the full pipeline before merging. Additionally, according to the component feature usage in our dashboard, usage of the awsui-value-large variant is minimal, which suggests a low regression risk:
- Links using the awsui-value-large variant account for ~0.3% of all link variants
- Boxes using the awsui-value-large variant account for ~0.1% of all box variants
Description
Make the font-weight themeable for the display large text.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.