Skip to content

chore: Make the font-weight themeable for display large text#4448

Merged
at-susie merged 7 commits intomainfrom
feat/theme-minor
Apr 20, 2026
Merged

chore: Make the font-weight themeable for display large text#4448
at-susie merged 7 commits intomainfrom
feat/theme-minor

Conversation

@at-susie
Copy link
Copy Markdown
Member

@at-susie at-susie commented Apr 16, 2026

Description

Make the font-weight themeable for the display large text.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (d634ab4) to head (7663130).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4448   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         933      933           
  Lines       29409    29409           
  Branches    10661    10660    -1     
=======================================
  Hits        28645    28645           
- Misses        716      757   +41     
+ Partials       48        7   -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@at-susie at-susie marked this pull request as ready for review April 20, 2026 08:31
@at-susie at-susie requested a review from a team as a code owner April 20, 2026 08:31
@at-susie at-susie requested review from mxschll and taheramr and removed request for a team and taheramr April 20, 2026 08:31
fontWeightHeadingM: '700',
fontWeightHeadingS: '700',
fontWeightHeadingXs: '700',
fontWeightDisplayLBold: '700',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add Bold to the token name? This suggests I should not set it to some other value than 700.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I will just simply remove "Bold"

Comment thread src/box/text.scss
}
&.value-large-variant {
@include styles.font-display-l;
font-weight: awsui.$font-box-value-large-weight;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run this through the pipeline? I am unsure if this will cause a regression.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think it's ok - but still :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change is narrowly scoped—only affecting box and link components when variant="awsui-value-large"—it may not be necessary to run it through the full pipeline before merging. Additionally, according to the component feature usage in our dashboard, usage of the awsui-value-large variant is minimal, which suggests a low regression risk:

  • Links using the awsui-value-large variant account for ~0.3% of all link variants
  • Boxes using the awsui-value-large variant account for ~0.1% of all box variants

@at-susie at-susie added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit 5b4e7cd Apr 20, 2026
49 checks passed
@at-susie at-susie deleted the feat/theme-minor branch April 20, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants