fix: Improve primary button disabled state contrast in one-theme - #4887
Merged
Conversation
ywyyu17
requested review from
Harsh-Anand-Singh,
YueyingLu and
pan-kot
and removed request for
a team
August 10, 2026 14:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4887 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 958 958
Lines 31317 31317
Branches 11566 11566
=======================================
Hits 30585 30585
Misses 686 686
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pan-kot
previously approved these changes
Aug 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 11, 2026
mxschll
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue:
Loading spinners in primary variant disabled buttons have a color contrast ratio of 1.90:1, which fails the WCAG 3:1 minimum
contrast requirement for non-text graphical elements. Users with low vision have difficulty identifying this content.
Fix:
Updated the primary button disabled state tokens in one-theme (light mode only):
New contrast ratio: 3:1 (#909090 on #f8f8f8), meeting the 3:1 requirement.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.