Skip to content

fix: Improve primary button disabled state contrast in one-theme - #4887

Merged
mxschll merged 1 commit into
mainfrom
dev-v3-ywy
Aug 17, 2026
Merged

fix: Improve primary button disabled state contrast in one-theme#4887
mxschll merged 1 commit into
mainfrom
dev-v3-ywy

Conversation

@ywyyu17

@ywyyu17 ywyyu17 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Description

Issue:
Loading spinners in primary variant disabled buttons have a color contrast ratio of 1.90:1, which fails the WCAG 3:1 minimum
contrast requirement for non-text graphical elements. Users with low vision have difficulty identifying this content.

Fix:
Updated the primary button disabled state tokens in one-theme (light mode only):

  • colorBackgroundButtonPrimaryDisabled: neutral400 (#b7b7b7) → neutral150 (#f8f8f8)
  • colorTextButtonPrimaryDisabled: neutral100 (#f9f9f9) → neutral500 (#909090)

New contrast ratio: 3:1 (#909090 on #f8f8f8), meeting the 3:1 requirement.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (f066dd8) to head (e45fcb6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4887   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         958      958           
  Lines       31317    31317           
  Branches    11566    11566           
=======================================
  Hits        30585    30585           
  Misses        686      686           
  Partials       46       46           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pan-kot
pan-kot previously approved these changes Aug 11, 2026
@mxschll
mxschll enabled auto-merge August 17, 2026 09:11
@mxschll
mxschll added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit 8028298 Aug 17, 2026
156 of 166 checks passed
@mxschll
mxschll deleted the dev-v3-ywy branch August 17, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants