fix: Enlarge SideNavigation expandable caret pointer target to 24px (WCAG 2.5.8) - #4907
Open
Harsh-Anand-Singh wants to merge 1 commit into
Open
fix: Enlarge SideNavigation expandable caret pointer target to 24px (WCAG 2.5.8)#4907Harsh-Anand-Singh wants to merge 1 commit into
Harsh-Anand-Singh wants to merge 1 commit into
Conversation
The expandable-link-group chevron button had a pointer target only as wide as its icon glyph (12px one-theme, 16px classic/VR), below the 24px minimum required by WCAG 2.5.8. Widen the clickable box to 24px using inline padding compensated by an equal negative margin, growing into the adjacent non-interactive gutter: inline-start for the start icon position, inline-end for the end icon position (where the label link's own click box sits flush against the caret's start edge). Width-only change: the glyph and label positions are unchanged, the label link keeps all of its clicks, and the vertical target already spans the full row height via flex stretch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4907 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 958 958
Lines 31317 31317
Branches 11566 11566
=======================================
Hits 30585 30585
Misses 686 686
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Harsh-Anand-Singh
marked this pull request as ready for review
August 14, 2026 13:23
Harsh-Anand-Singh
requested review from
SpyZzey and
YueyingLu
and removed request for
a team and
SpyZzey
August 14, 2026 13:23
Harsh-Anand-Singh
temporarily deployed
to
allure-report
August 14, 2026 19:09 — with
GitHub Actions
Inactive
Harsh-Anand-Singh
temporarily deployed
to
allure-report
August 16, 2026 15:00 — with
GitHub Actions
Inactive
YueyingLu
approved these changes
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a WCAG 2.5.8 (Target Size Minimum) finding: the SideNavigation expandable-link-group chevron caret button had a pointer target only as wide as its icon glyph, 12px in One Theme, 16px in Classic/Visual Refresh, below the 24px minimum.
This is a width-only change. The vertical target was already conformant: the caret button stretches to the full row height (28px comfortable / 24px compact) via flex stretch.
The clickable box is widened to 24px using inline padding compensated by an equal negative margin, so the extra width lands entirely in the adjacent non-interactive gutter:
space-lnegative-margin seating).withIcons): grows into the trailing gutter instead, because the label link's own click box (its negative-margin overhang) sits flush against the caret's inline-start edge, growing start-ward there would capture the link's clicks.Zero layout shift: the caret glyph and the label link do not move (verified pixel-identical positions before/after in both themes), and pixel probes at the caret/link boundary confirm click ownership is unchanged. Behavior is the same across Classic, Visual Refresh, and One Theme, the tokens involved resolve identically; only the padding delta differs because the icon glyph is 16px vs 12px. Stacked link groups tile cleanly (24px target ≤ 24px compact row pitch), with no target overlap between rows.
Related links, issue #, if available: n/a
How has this been tested?
src/expandable-section+src/side-navigation(365 tests) pass.src/expandable-section/__integ__+src/side-navigation/__integ__pass.inline-icon-pointer-targetprecedent; coverage is the a11y audit re-run plus existing permutation screenshots (visual regression runs in CI on this PR).Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.