Skip to content

chore: Allow Portal's hidden SSR placeholder in the SSR test #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanZlion merged 2 commits into from
Aug 18, 2026
Merged

chore: Allow Portal's hidden SSR placeholder in the SSR test #4908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99e161c
chore: Allow Portal's hidden SSR placeholder in the SSR test
TrevorBurnham Aug 15, 2026
36c9613
Merge branch 'main' into fix-ssr-test-portal-placeholder
TrevorBurnham Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/__tests__/functional-tests/ssr.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ afterEach(() => {

const vrOnlyComponents = ['app-layout-toolbar'];

// Components whose entire tree is rendered through a portal. The server renderer has no
// container to portal into, so none of their content reaches the server markup. Portal
// itself renders a hidden placeholder element in its place, so that the markup matches
// the first client render and hydration succeeds; the client replaces it on the first
// commit. Older component-toolkit versions emit nothing at all, hence the optional match.
const portaledComponents = ['modal', 'tooltip'];
const emptyOrHiddenPlaceholder = /^(<span style="display:none"><\/span>)?$/;

test('ensure is it not DOM', () => {
expect(typeof window).toBe('undefined');
expect(typeof CSS).toBe('undefined');
Expand All @@ -34,9 +42,9 @@ for (const componentName of getAllComponents().filter(component => vrOnlyCompone
const { default: Component } = requireComponent(componentName);
const props = getRequiredPropsForComponent(componentName);
const content = renderToStaticMarkup(React.createElement(Component, props, 'test content'));
if (componentName === 'modal' || componentName === 'tooltip') {
// modal and tooltip use portal API which does not work on server and returns an empty content
expect(content.length).toEqual(0);
if (portaledComponents.indexOf(componentName) !== -1) {
expect(content).not.toContain('test content');
expect(content).toMatch(emptyOrHiddenPlaceholder);
} else {
expect(content.length).toBeGreaterThan(0);
}
Expand Down
Loading