Improve PHP 8.5+ support by avoiding deprecated setAccessible() calls#124
Merged
Improve PHP 8.5+ support by avoiding deprecated setAccessible() calls#124
setAccessible() calls#124Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to improve compatibility with newer PHP versions (PHP 8.5+) by avoiding deprecated ReflectionProperty::setAccessible() calls while keeping behavior compatible with older PHP versions.
Changes:
- Guard
ReflectionProperty::setAccessible(true)behind aPHP_VERSION_ID < 80100check in tests and runtime code paths. - Bump ReactPHP dependency constraints (
react/promise,react/socket) and dev dependency (react/event-loop) to newer versions. - Update CI to run on
ubuntu-24.04, add PHP 8.5 to the test matrix, and updateactions/checkoutmajor version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ServerTest.php | Conditionally avoids calling deprecated setAccessible() when reading private $loop via reflection. |
| tests/ClientTest.php | Conditionally avoids calling deprecated setAccessible() when reading private $connector via reflection. |
| src/Client.php | Conditionally avoids calling deprecated setAccessible() when reflecting on Exception::$trace. |
| composer.json | Updates ReactPHP dependency constraints to newer compatible releases. |
| .github/workflows/ci.yml | Updates CI runner, adds PHP 8.5, and bumps checkout action major version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves PHP 8.5+ support by avoiding the deprecated
setAccessible()call as discussed in clue/framework-x#297.Builds on top of #123, #122, reactphp/socket#325, reactphp/promise#264, reactphp/event-loop#282, and clue/framework-x#297