Repository navigation
Update test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5 - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrow test-environment changes consistently support PHPUnit 8.5 on PHP 7.2, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Updates the test environment to support PHPUnit 8.5 on legacy PHP 7.2 while preserving existing CI configuration selection.
Changes:
- Allows PHPUnit 8.5 as a development dependency.
- Consolidates the CI test command while retaining the legacy configuration for PHP below 7.3.
- Corrects PHPUnit version ranges in test-helper comments; runtime behavior is unchanged.
| File | Description |
|---|---|
tests/TestCase.php |
Corrects comments describing mock-builder compatibility. |
composer.json |
Adds ^8.5 to the allowed PHPUnit versions. |
.github/workflows/ci.yml |
Combines PHPUnit steps with conditional legacy configuration selection. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to fix tests on legacy PHP 7.2 with PHPUnit 8.5. This is needed to run the tests on legacy platforms due to recent upstream changes as discussed in clue/reactphp-redis#180.
Builds on top of #16, #12 and clue/reactphp-redis#180