Add docs for AC disk bandwidth accounting#23195
Conversation
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
|
hi @sumeerbhola ! pinging you for review as the author of cockroachdb/cockroach#159436 please let me know if anything is wrong in this PR! also if anything is missing and you feel we need to provide more context to users. happy to update |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
@angeladietz since you took over cockroachdb/cockroach#159436
@sumeerbhola made 1 comment.
Reviewable status:complete! 0 of 0 LGTMs obtained.
|
This change is |
jhlodin
left a comment
jhlodin
left a comment
There was a problem hiding this comment.
One suggestions, otherwise LGTM
| - `admission.sql_kv_response.enabled` for work performed in the SQL layer when receiving [KV responses]({% link {{ page.version.version }}/architecture/distribution-layer.md %}). | ||
| - `admission.sql_sql_response.enabled` for work performed in the SQL layer when receiving [DistSQL responses]({% link {{ page.version.version }}/architecture/sql-layer.md %}#distsql). | ||
| - `kvadmission.store.snapshot_ingest_bandwidth_control.enabled` to optionally limit the disk impact of ingesting snapshots on a node. This cluster setting is in [Preview]({% link {{ page.version.version }}/cockroachdb-feature-availability.md %}#features-in-preview). | ||
| - `kvadmission.store.snapshot_ingest_bandwidth_control.enabled` to optionally limit the disk impact of ingesting [snapshots]({% link {{ page.version.version }}/architecture/replication-layer.md %}#snapshots) on a node. This cluster setting is in [Preview]({% link {{ page.version.version }}/cockroachdb-feature-availability.md %}#features-in-preview). |
There was a problem hiding this comment.
@angeladietz Joe pointed out the 'Preview' tagging on these settings. However the title of https://cockroachlabs.atlassian.net/browse/CRDB-47073 is "ac: disk write bandwidth accounting GA"
so it looks like the 'Preview' tagging here is incorrect and I should remove it. can you please confirm my understanding is correct? if so, i'll delete the "preview" language here before merging
|
ok given that we have LGTMs and the release is on Monday I'm going to merge this now, we can fast-follow if updates are needed |
sorry for the delay here. Yeah I think keeping it as "preview" is correct for now, we can let you know when it should be updated to claim that its GA. |
5 participants
Fixes DOC-12206, DOC-15809