Skip to content

fix: use semantic table backgrounds#2708

Merged
claudiacodacy merged 5 commits into
masterfrom
codex/fix-table-dark-mode
Jul 16, 2026
Merged

fix: use semantic table backgrounds#2708
claudiacodacy merged 5 commits into
masterfrom
codex/fix-table-dark-mode

Conversation

@claudiacodacy

Copy link
Copy Markdown
Contributor

Summary

  • replace hard-coded table background colors with semantic documentation tokens
  • add the dark-mode-aware informational background token
  • preserve non-color inline table styles

Validation

  • mkdocs build --strict

@claudiacodacy claudiacodacy requested a review from a team as a code owner July 16, 2026 15:02
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Overall readability score: 53.98 (🟢 +0)

File Readability
roles-and-permissions-for-organizations.md 61.91 (🟢 +0)
why-does-codacy-show-unexpected-coverage-changes.md 65.31 (🟢 +0)
index.md 48.26 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
roles-and-permissions-for-organizations.md 61.91 38.32 8.84 12.2 12.93 6.22
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
why-does-codacy-show-unexpected-coverage-changes.md 65.31 52.39 10.02 11.8 11.31 6.15
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
index.md 48.26 25.39 11.43 14.7 13.75 6.93
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 53.98 42.98 10.93 12.34 12.28 8.04
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces hardcoded hex color values with CSS custom properties across several documentation files, and defines the new --docs-info-bg variable in tokens.css. A review comment correctly identifies an issue with the CSS selector table:not(data-exclude) in roles-and-permissions-for-organizations.md, suggesting it be updated to table:not([data-exclude]) to properly target the attribute.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/organizations/roles-and-permissions-for-organizations.md
@github-actions github-actions Bot temporarily deployed to Netlify July 16, 2026 15:03 Inactive

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This review focused on the transition from hard-coded HEX values to semantic CSS tokens for documentation tables. While the core objective of defining and using the new --docs-info-bg token is met, two main areas require attention.

First, the CSS selector in the permissions documentation needs to be broader to include header cells (th), as the current td-only selector will likely fail to style table headers correctly. Second, several files exhibit inconsistent token usage where backgrounds are semantic but text colors remain hard-coded. This inconsistency reduces the effectiveness of the theme-aware tokens, particularly in dark mode. No security flaws were found, and Codacy analysis indicates the changes are up to standards, but these logic and consistency issues should be addressed prior to merging.

1 comment outside of the diff
docs/faq/code-analysis/why-does-codacy-show-unexpected-coverage-changes.md

line 393-400 ⚪ LOW RISK
Suggestion: To complete the migration to semantic tokens in this style block and ensure better dark mode support, consider replacing these hardcoded hex values with semantic variables.\n\nsuggestion\n.text-green {\n color: var(--docs-success);\n}\n\n/*Red text*/\n.text-red {\n color: var(--docs-danger);\n}\n

Test suggestions

  • Missing recommended test scenario: Verify that .background-red correctly utilizes the --docs-danger-bg token\n- [ ] Missing recommended test scenario: Verify that the permissions table header row utilizes the --docs-bg-brand token\n- [ ] Missing recommended test scenario: Verify that .yes, .no, and .maybe classes use success, danger, and info background tokens respectively\n- [ ] Missing recommended test scenario: Verify the presence and correct values of --docs-info-bg in light and dark mode CSS blocks
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Missing recommended test scenario: Verify that .background-red correctly utilizes the --docs-danger-bg token\n- [ ] Missing recommended test scenario: Verify that the permissions table header row utilizes the --docs-bg-brand token\n- [ ] Missing recommended test scenario: Verify that .yes, .no, and .maybe classes use success, danger, and info background tokens respectively\n- [ ] Missing recommended test scenario: Verify the presence and correct values of --docs-info-bg in light and dark mode CSS blocks

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread docs/organizations/roles-and-permissions-for-organizations.md
Comment thread theme/stylesheets/tokens.css Outdated
Comment thread theme/stylesheets/tokens.css Outdated
@github-actions github-actions Bot temporarily deployed to Netlify July 16, 2026 15:10 Inactive
@github-actions github-actions Bot temporarily deployed to Netlify July 16, 2026 15:16 Inactive
@claudiacodacy claudiacodacy enabled auto-merge (squash) July 16, 2026 15:21
@claudiacodacy claudiacodacy merged commit 736d8fd into master Jul 16, 2026
5 checks passed
@claudiacodacy claudiacodacy deleted the codex/fix-table-dark-mode branch July 16, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants