chore: fix discovery of tests under Windows#5276
Open
cdprete wants to merge 1 commit intocodecentric:masterfrom
Open
chore: fix discovery of tests under Windows#5276cdprete wants to merge 1 commit intocodecentric:masterfrom
cdprete wants to merge 1 commit intocodecentric:masterfrom
Conversation
cdprete
force-pushed
the
master
branch
2 times, most recently
from
4cd93e2 to
b45583c
Compare
cdprete
changed the title
cdprete
force-pushed
the
master
branch
4 times, most recently
from
d45b2f9 to
2374a9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreating this PR since I'm not allowed to reopen #5273.
It seems like that removing the
test.rootproperty to makevitestdefault to the parentrootproperty was the cause of the CSS hashes changing.This has now been reverted.
Also, the
formatWithDataTypestests have been fixed to not rely on the fact that the running Node instance has thede-DElocale set.Moreover, depending on how the Node binary was built, locales/languages apart English may not be available.
See https://github.com/nodejs/node/blob/main/BUILDING.md#intl-ecma-402-support which may explains why the
LANGenv variable set in theviteconfig may be potentially ignored.