fix: download CLI to temp dir and retry GPG key import - #68
Open
thomasrockhu-codecov wants to merge 4 commits into
Open
fix: download CLI to temp dir and retry GPG key import#68thomasrockhu-codecov wants to merge 4 commits into
thomasrockhu-codecov wants to merge 4 commits into
Conversation
Fixes two regressions in the wrapper script: 1. Dirty git state (codecov/codecov-action#1851, codecov/codecov-action#1804): The binary, SHA256SUM, and SHA256SUM.sig files were downloaded into the working directory (repo root) and never cleaned up. Now downloads to a mktemp -d directory with an EXIT trap that removes it automatically. 2. GPG import failures (codecov/codecov-action#1876): The key import used `echo "$(curl ...)" | gpg --import` which strips trailing newlines from the PGP key, had no retries, and no error checking. Now pipes curl directly to gpg with a 3-attempt retry loop and explicit failure reporting. Made-with: Cursor
Collaborator
Author
|
Closing as part of stale P5 PR cleanup. |
Keep downloads in the working directory by default while allowing callers to isolate and remove temporary verification artifacts. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
thomasrockhu-codecov
marked this pull request as ready for review
August 11, 2026 00:32
calvin-codecov
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanupsetting (CC_CLEANUPin the packaged wrapper), defaulting tofalsedownload_onlyandbinary_locationworkflowsscripts/;dist/remains generated and unchangedTest plan
bash -n scripts/*.shpython -m pytestscripts/dist/codecov.shthrough the normal release tooling