Skip to content

fix(devcontainer): use 0o755 for feature directories (missing execute bit) #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnstcn wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −3
Open

fix(devcontainer): use 0o755 for feature directories (missing execute bit) #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f3a659
fix(devcontainer): use 0o755 for feature directories so non-root user…
johnstcn Apr 10, 2026
670d34b
fix(devcontainer): wrap per-feature MkdirAll error with ref and path …
johnstcn Apr 10, 2026
3304543
test(devcontainer): assert feature directories are created with 0o755
johnstcn Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions devcontainer/devcontainer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ func (s *Spec) compileFeatures(fs billy.Filesystem, devcontainerDir, scratchDir
}

featuresDir := filepath.Join(scratchDir, "features")
err := fs.MkdirAll(featuresDir, 0o644)
err := fs.MkdirAll(featuresDir, 0o755)
Comment thread
johnstcn marked this conversation as resolved.
if err != nil {
return "", nil, fmt.Errorf("create features directory: %w", err)
}
Expand Down Expand Up @@ -277,8 +277,8 @@ func (s *Spec) compileFeatures(fs billy.Filesystem, devcontainerDir, scratchDir
featureSha := md5.Sum([]byte(featureRefRaw))
Comment thread
johnstcn marked this conversation as resolved.
featureName := filepath.Base(featureRef)
featureDir := filepath.Join(featuresDir, fmt.Sprintf("%s-%x", featureName, featureSha[:4]))
if err := fs.MkdirAll(featureDir, 0o644); err != nil {
return "", nil, err
if err := fs.MkdirAll(featureDir, 0o755); err != nil {
Comment thread
johnstcn marked this conversation as resolved.
return "", nil, fmt.Errorf("create feature directory for %s at %s: %w", featureRefRaw, featureDir, err)
}
spec, err := features.Extract(fs, devcontainerDir, featureDir, featureRefRaw)
if err != nil {
Expand Down
9 changes: 9 additions & 0 deletions devcontainer/devcontainer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,15 @@ WORKDIR `+featureTwoDir+`
ENV POTATO=example
RUN VERSION="potato" _CONTAINER_USER="1000" _REMOTE_USER="1000" ./install.sh
USER 1000`, params.DockerfileContent)

// Verify feature directories are created with 0o755 (not
// 0o644) so non-root container users can traverse them.
for _, dir := range []string{workingDir + "/features", featureOneDir, featureTwoDir} {
info, err := fs.Stat(dir)
require.NoError(t, err, "stat %s", dir)
require.Equalf(t, os.FileMode(0o755), info.Mode()&os.ModePerm,
"directory %s should be 0o755, got %04o", dir, info.Mode()&os.ModePerm)
}
})

t.Run("WithBuildContexts", func(t *testing.T) {
Expand Down
Loading