Skip to content

chore: bump go-git to 5.19.2 and go-billy to 5.9.0 - #533

Merged
johnstcn merged 2 commits into
mainfrom
bump-go-git
Oct 2, 2026
Merged

johnstcn merged 2 commits into
mainfrom
bump-go-git

Conversation

@stirby

@stirby stirby commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Bumps go-git 5.16.5 to 5.19.2 and go-billy 5.6.2 to 5.9.0. govulncheck: 75 reachable to 53, fixing 22, including transitive x/crypto.

This is the most relevant set for envbuilder, which clones user-supplied repositories and submodules with go-git. Fixed advisories include worktree symlink following, malicious ref names writing outside .git, crafted repos modifying submodule .git dirs, credential leaks on cross-host redirects, and go-billy path traversal.

Other changes:

  • Tests: osfs.WithChrootOS() is deprecated in go-billy 5.9 (staticcheck SA1019 fails lint). Switched to osfs.WithBoundOS() in git/git_test.go and integration/integration_test.go. Production code uses osfs.New("/") and is unaffected.
  • Please review submodule behaviour (feat: add git submodule support #485/fix(git): fix submodule init on workspace restart #518) with extra care. go-git 5.17 to 5.19 changed submodule and worktree handling for the symlink fixes. Unit tests pass locally, and CI integration tests cover submodules.

Part of a set of independent dependency PRs. All touch go.mod/go.sum, so rebase with go mod tidy after the first one merges.

Generated by Coder Agents on behalf of @stirby.

@johnstcn
johnstcn marked this pull request as ready for review October 2, 2026 09:57
Copilot AI balanced review requested due to automatic review settings October 2, 2026 09:57
@johnstcn johnstcn self-assigned this Oct 2, 2026
@johnstcn
johnstcn merged commit 7ef6552 into main Oct 2, 2026
5 checks passed
@johnstcn
johnstcn deleted the bump-go-git branch October 2, 2026 09:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The title, description, and vulnerability claims do not match the actual rebased diff.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates go-git to its security-focused v5.19.2 patch and aligns transitive Go dependencies.

Changes:

  • Upgrades go-git from v5.19.1 to v5.19.2.
  • Updates related golang.org/x dependencies and checksums.
  • No go-billy or test-file changes are present.
File Description
go.mod Updates dependency versions.
go.sum Refreshes module checksums.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread go.mod
github.com/gliderlabs/ssh v0.3.8
github.com/go-git/go-billy/v5 v5.9.0
github.com/go-git/go-git/v5 v5.19.1
github.com/go-git/go-git/v5 v5.19.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants