fix(claude-code): don't pass --dangerously-skip-permissions in auto mode#846
Open
bdevore17 wants to merge 1 commit intocoder:mainfrom
Open
fix(claude-code): don't pass --dangerously-skip-permissions in auto mode#846bdevore17 wants to merge 1 commit intocoder:mainfrom
bdevore17 wants to merge 1 commit intocoder:mainfrom
Conversation
The task reporting code path unconditionally added --dangerously-skip-permissions regardless of the configured permission_mode. This meant workspaces using permission_mode="auto" got both --permission-mode auto AND --dangerously-skip-permissions, defeating the purpose of auto mode. Now only adds --dangerously-skip-permissions when no explicit permission mode is set (backward compat) or when bypassPermissions is the chosen mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start.shunconditionally adds--dangerously-skip-permissionsregardless of the configuredpermission_modepermission_mode = "auto"get both--permission-mode autoand--dangerously-skip-permissions, which defeats the purpose of auto mode--dangerously-skip-permissionswhen no explicit permission mode is set (backward compat) or whenbypassPermissionsis chosenTest plan
claude-continue-resume-task-session-auto-modetest verifying--dangerously-skip-permissionsis NOT passed whenpermission_mode=autoclaude-auto-permission-modetest to assert--dangerously-skip-permissionsis absentclaude-continue-resume-task-sessiontest still verifies default (no permission_mode) includes--dangerously-skip-permissions