Skip to content

Fix serialization of VolMesh cell attributes - #1531

Open
ArianMoeini wants to merge 1 commit into
compas-dev:mainfrom
ArianMoeini:fix/volmesh-cell-serialization
Open

ArianMoeini wants to merge 1 commit into
compas-dev:mainfrom
ArianMoeini:fix/volmesh-cell-serialization

Conversation

@ArianMoeini

Copy link
Copy Markdown

Summary

  • Serialize VolMesh cell attributes from key-value pairs so cells with custom attributes can be saved.
  • Add a JSON round-trip regression test with attributes on multiple cells.
  • Add contributor credit as requested by the contribution guide.

Closes #1396.

Tests

  • PYTHONPATH=src:/private/tmp/compas-test-deps python -m pytest tests/compas/datastructures/test_volmesh.py -q — 37 passed.
  • git diff --check — passed.

@tomvanmele tomvanmele left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VolMesh cell attributes cannot be serialized

2 participants