Skip to content

Update docker.io/library/golang Docker tag to v1.26.9 (main) #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
red-hat-konflux wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update docker.io/library/golang Docker tag to v1.26.9 (main) #3372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

## Build

FROM docker.io/library/golang:1.26.7@sha256:e30143be198ab04cf7ba25fba83ab3a692ca584c994aad0bf131fa0eb32dd8c1 AS build
FROM docker.io/library/golang:1.26.9@sha256:37cfcca63222ec499bec5e8ad7aad52dbf7529db36d5812b8eae2f0621aa92d6 AS build

Check failure on line 19 in Dockerfile

View workflow job for this annotation

GitHub Actions / Test 

Containerfile version incompatible, saw 1.26.9, running with version: 1.26.7

@fullsend-ai-review fullsend-ai-review Bot Oct 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] protected-path

The PR modifies the protected path Dockerfile (listed in REVIEW_PROTECTED_PATHS) without a linked issue or in-description rationale justifying the change. The PR body is Renovate's default template for a patch-level base-image bump (golang 1.26.7 → 1.26.9 with corresponding SHA256 digest pin). The repository's renovate.json configures automated updates for this file, but protected-path changes always require explicit human approval regardless of automation.

Suggested fix: A human maintainer must review and approve this change. If routine Renovate base-image bumps should be considered pre-authorized for Dockerfile, document the carve-out explicitly (in the PR body and/or a tracked issue) so future automated updates can reference it.


@fullsend-ai-review fullsend-ai-review Bot Aug 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] metadata inconsistency

The PR title says 'Update ... to v1.26.4' but the actual diff bumps the image from golang:1.26.3 to golang:1.26.5, skipping 1.26.4 entirely. The PR body mentions '1.26.3 to 1.26.4, Pending: 1.26.5', confirming the title is stale relative to the committed change. This is a cosmetic mismatch typical of Renovate bot rebases but could cause confusion when triaging or auditing dependency updates.

@fullsend-ai-review fullsend-ai-review Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] metadata inconsistency

The PR title references v1.26.4, but the actual diff updates the golang image from 1.26.3 to 1.26.5. The PR body lists the change as 1.26.3 → 1.26.4 with 1.26.5 as pending, yet the committed code already uses 1.26.5. This is likely due to Renovate rebasing onto a newer version after the PR was initially created.

@fullsend-ai-review fullsend-ai-review Bot Aug 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] protected-path

This PR modifies Dockerfile, which is a protected governance/infrastructure path. The PR has no linked issue providing authorization for the change. Human approval is required for all changes to protected paths.

Suggested fix: Ensure a human reviewer approves changes to the Dockerfile. Consider linking to an issue that authorizes this infrastructure change.

ARG TARGETOS
ARG TARGETARCH
Expand Down
Loading