Refactor compose_run_linux_test#4845
Open
sathiraumesh wants to merge 1 commit intocontainerd:mainfrom
Open
Conversation
46 tasks
sathiraumesh
force-pushed
the
refactor_compose_run_linux_test_4613
branch
from
3eb2166 to
1c62fbd
Compare
Migrated 9 out of 10 tests in compose_run_linux_test.go from legacy testutil.NewBase to the nerdtest/tigron framework. Replaced unbuffer wrapper with WithPseudoTTY, goroutine polling with cmd.Background and EnsureContainerStarted, and hardcoded ports with portlock.Acquire. Signed-off-by: sathiraumesh <sathiraumesh@gmail.com>
sathiraumesh
force-pushed
the
refactor_compose_run_linux_test_4613
branch
from
1c62fbd to
83f48b8
Compare
Contributor
Author
|
@AkihiroSuda this is up for review |
Member
|
HI, @sathiraumesh Thanks for creating this PR. It looks like the test you refactored is failing. Could you please check it? https://github.com/containerd/nerdctl/actions/runs/24600266536/job/71937779334?pr=4845
https://github.com/containerd/nerdctl/actions/runs/24600266519/job/71937648351?pr=4845
|
Contributor
Author
|
sure @haytok ill have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compose_run_linux_test.gofrom legacytestutil.NewBasetonerdtest.Setup()/ tigron frameworkNot included
TestComposePushAndPullWithCosignVerifyremains on legacy harness — blocked ontestregistryrequiring*testutil.Base, A seperate PR would be better of this