improvements in namespace inspect command#4864
Open
Exar04 wants to merge 4 commits intocontainerd:mainfrom
Open
improvements in namespace inspect command#4864Exar04 wants to merge 4 commits intocontainerd:mainfrom
Exar04 wants to merge 4 commits intocontainerd:mainfrom
Conversation
… in that namespace Signed-off-by: Exar04 <yashdhadwe@gmail.com>
Author
|
Should I add all the data of containers? like right now its just exposing id, name, and image |
Signed-off-by: Exar04 <yashdhadwe@gmail.com>
Author
|
I’m having trouble understanding the failed tests. Could someone please help explain them? |
Member
|
Hi, @Exar04 |
Member
|
Why not just use |
this test checks if the command is giving valid json output Signed-off-by: Exar04 <yashdhadwe@gmail.com>
Author
|
@AkihiroSuda this pr adds additional metadata for a given namespace The issue stated
which is namespace name, images, volumes, containers and labels $ nerdctl ns list
NAME CONTAINERS IMAGES VOLUMES LABELS
default 2 4 0
default_history 0 0 0 Previously, the command only returned the namespace name and labels -> $ nerdctl ns inspect default
[
{
"Name": "default",
"Labels": null
}
]
Now this PR adds container data as well -> $ nerdctl ns inspect default
[
{
"Name": "default",
"Labels": null,
"Containers": [
{
"id": "1d92cb93e730746035be84ff8d32faa60240d85ecf8c38f99ae50c6aaa246b7e",
"image": "docker.io/library/hello-world:latest",
"name": "io.containerd.runc.v2"
},
{
"id": "7c43b7c3c735755d97353b9afe85d47690cb7511eceac63d0e123ac3060309f1",
"image": "docker.io/library/nginx:latest",
"name": "io.containerd.runc.v2"
}
]
}
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reference : #3851
this pr adds information of containers in the given namespace