fix(terminal-security): block more destructive filesystem commands#13006
Open
Solaris-star wants to merge 2 commits into
Open
fix(terminal-security): block more destructive filesystem commands#13006Solaris-star wants to merge 2 commits into
Solaris-star wants to merge 2 commits into
Conversation
Headless/auto mode relies on the terminal-security denylist as the last
backstop. Expand critical detection so rm -rf against /home, /root, /var,
/opt, /srv and $HOME/${HOME} is disabled, and always-disable shred,
wipefs, truncate -s, find -delete, and pkexec.
shell-quote drops unquoted $HOME to an empty token, so also match home
targets on the original command string. Update unit coverage.
Fixes continuedev#13001
dosubot
Bot
added
the
size:L
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Headless/auto mode sets Bash to allow, so the terminal-security denylist is the last backstop against destructive commands. Several high-impact patterns were missing.
Fixes #13001
Testing
cd packages/terminal-security && npm test-> 236 passed