fix: restore the author metadata that npm drops from the package - #3
Merged
Conversation
package.json declared the author as an array:
"author": ["Michael Martinez", "Helmut Dersch"]
npm does not accept an array there. `author` names one person, and
`contributors` is the array. npm therefore dropped the field, and the published
2.2.0 carries no author at all:
$ npm view @cornerstonejs/jpeg-lossless-decoder-js author --json
{}
So the package lost the attribution to the two people who wrote the decoder.
The unscoped jpeg-lossless-decoder-js has the same defect, and this fork
inherited it.
Both names are kept, in the shape npm reads:
"author": "Michael Martinez",
"contributors": ["Helmut Dersch"]
Michael Martinez wrote the JavaScript port and the selection value 2 to 7
support; Helmut Dersch wrote the original Java decoder. README.md's
acknowledgments section is the source for both.
Verified: `npm pkg get` normalizes the manifest to a string author and a
contributors array, the packed tarball's package.json carries both, the lint
passes and all 54 tests pass.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bill Wallace maintains this fork: the byte-aligned-end-of-scan fix in 03bb80c, and the work that publishes the fork as @cornerstonejs/jpeg-lossless-decoder-js. The entry is the name alone, which matches the two entries beside it. npm also accepts "Name <email> (url)", and an entry in a published package is public, so the email stays out unless its owner asks for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defect
package.jsondeclared the author as an array:npm does not accept an array there.
authornames one person, andcontributorsis the array. npm therefore drops the field, and the published2.2.0 carries no author at all:
The package lost the attribution to the people who wrote the decoder. The
unscoped
jpeg-lossless-decoder-jshas the same defect, and this forkinherited it.
The fix
Both original names stay, in the shape npm reads, and the fork's maintainer
joins them:
support.
03bb80c0, and the work that publishes it as@cornerstonejs/jpeg-lossless-decoder-js.README.md's acknowledgments section is the source for the first two.Each entry is a name alone, which is the form the existing entries used. npm
also accepts
"Name <email> (url)"; an entry in a published package is public,so no email is included.
What this releases
The title is
fix:, so the merge releases 2.2.1.tools/check-pr-title.mjsagrees:Two things follow, and both are the point:
trusted publishing. 2.2.0 went out by hand, because npm cannot create a
package name through OIDC. This release exercises
release→publish→github-releasefor the first time.publish from CI, so 2.2.0 has none — its
distcarries the registrysignature and no
attestations. 2.2.1 will carry one.If the publish job fails, the version commit and the
v2.2.1tag are alreadyon
main; re-run the workflow withworkflow_dispatchand it publishes fromthere.
Verified
npm pkg get author contributorsnormalizes to a string author and acontributors array of two.
package.jsoncarries the fields.🤖 Generated with Claude Code