Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Sync Gateway’s Rosmar dependency to pick up hierarchical subdoc support and enables previously CBS-only tests to run under Rosmar (while still skipping the subset that truly requires the gocb DCP client).
Changes:
- Bump
github.com/couchbaselabs/rosmarto a newer pseudo-version that includes hierarchical subdoc support. - Remove
UnitTestUrlIsWalrus()skips from attachment compaction and metadata/subdoc tests so they run in Rosmar. - Replace some
ErrXattrNotFoundassertions withbase.RequireXattrNotFoundError, and gate rollback/DCP-client-specific tests withbase.TestRequiresGocbDCPClient.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rest/attachmentcompactiontest/attachment_compaction_api_test.go | Removes Walrus skips for attachment compaction API tests; explicitly skips the rollback test that requires gocb DCP client. |
| db/attachment_compaction_test.go | Enables attachment compaction unit tests under Rosmar; improves xattr-not-found assertions; uses TestRequiresGocbDCPClient where appropriate. |
| base/collection_xattr_test.go | Enables metadata store subdoc/xattr tests under Rosmar now that hierarchical subdoc support is available. |
| go.mod | Updates the Rosmar dependency version. |
| go.sum | Adds checksums for the new Rosmar pseudo-version. |
| github.com/couchbaselabs/go-fleecedelta v0.0.0-20220909152808-6d09efa7a338 | ||
| github.com/couchbaselabs/gocbconnstr v1.0.5 | ||
| github.com/couchbaselabs/rosmar v0.0.0-20260528075904-428892269c04 | ||
| github.com/couchbaselabs/rosmar v0.0.0-20260618211319-52b510eebbb4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-4232 uptake rosmar hierarchical subdoc support
Uses couchbaselabs/rosmar#69
Dependencies (if applicable)
Do not merge until upstream PR is merged and go.mod is updated.