fix(ast): explicitly instantiate two-argument ConstantExprInfo populate

[liuq]

TypeBuilder::buildArray calls ASTVisitor::populate(ConstantExprInfo<std::uint64_t>&, clang::Expr const*) for DependentSizedArrayType. That template is defined in ASTVisitor.cpp, but only the three-argument overload (..., llvm::APInt const&) is explicitly instantiated there. The two-argument one exists in the object file only as an implicit instantiation from the three-argument body. When the compiler inlines that call, no symbol is emitted, and linking tools/mrdocs fails:

Undefined symbols for architecture arm64:
  "void mrdocs::ASTVisitor::populate<unsigned long long>(mrdocs::ConstantExprInfo<unsigned long long>&, clang::Expr const*)", referenced from:
      mrdocs::TypeBuilder::buildArray(clang::ArrayType const*) in libmrdocs-core.a[11](TypeBuilder.cpp.o)
ld: symbol(s) not found for architecture arm64

I hit this building 2026.9.29 (Release, -O3) on macOS arm64 against Homebrew's llvm 23.1.2, for a Homebrew formula. The pinned LLVM build happens not to inline the call, which is why CI doesn't see it.

Changes

• Source: add the missing explicit instantiation of the two-argument populate<std::uint64_t> in src/mrdocs/AST/ASTVisitor.cpp.

Testing

With this change, the configuration above builds and links, and mrdocs generates documentation for a sample project. There's no new test: the failure only shows up at link time with a toolchain that inlines the call, and none of the CI toolchains do.

Documentation

None needed; this is a build fix with no user-visible behavior change.

🤖 Generated with Claude Code

[github-actions]

⚠️ Warnings

Warning

Source changed but no tests or fixtures were updated.

🧾 Changes by Scope

Scope	Lines Δ%	Lines Δ	Lines +	Lines -	Files Δ	Files +	Files ~	Files ↔	Files -
🛠️ Source	100%	7	7	-	1	-	1	-	-
Total	100%	7	7	-	1	-	1	-	-

Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)

🔝 Top Files

• src/mrdocs/AST/ASTVisitor.cpp (Source): 7 lines Δ (+7 / -0)

Generated by 🚫 dangerJS against b05c440

[Copilot]

Copilot review overview

🟢 Approval recommended

The focused instantiation correctly addresses the reported linker failure without changing runtime behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Adds the missing explicit template instantiation needed to prevent optimized macOS arm64 link failures.

Changes:

• Explicitly instantiates the two-argument populate<std::uint64_t> overload.

File	Description
src/​mrdocs/​AST/​ASTVisitor.cpp	Ensures the required template specialization emits a linkable symbol.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[cppalliance-bot]

An automated preview of the documentation is available at https://1334.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-04 07:47:26 UTC