Repository navigation
fix(config): non-standard attributes off by default - #1336
Merged
alandefreitas merged 1 commit intoOct 6, 2026
Merged
alandefreitas merged 1 commit into
alandefreitas merged 1 commit into
Conversation
alandefreitas
enabled auto-merge
October 6, 2026 16:01
Contributor
✨ Highlights
🧾 Changes by Scope
🔝 Top Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1336 +/- ##
========================================
Coverage 83.12% 83.12%
========================================
Files 35 35
Lines 3662 3662
Branches 844 844
========================================
Hits 3044 3044
Misses 410 410
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
An automated preview of the documentation is available at https://1336.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-10-06 17:08:13 UTC |
gennaroprota
reviewed
Oct 6, 2026
alandefreitas
disabled auto-merge
October 6, 2026 16:30
alandefreitas
force-pushed
the
fix/non-standard-attributes-default
branch
from
October 6, 2026 16:59
f16611e to
ed6d72a
Compare
alandefreitas
enabled auto-merge
October 6, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes one default. MrDocs documented compiler-specific attributes unless a project turned the option off, so the reference of a few Boost libraries, and our own, shows
[[__visibility__, __exclude_from_explicit_instantiation__]]on members inherited from the standard library. Export macros and libc++ put those there for the linker, not for a reader. With the option off by default, only the standard C++ attributes appear, and a project that wants the rest turns it on. The change is small, but it is live in Boost documentation builds today, so I would like it in soon.Changes
The default of the option is now off, and I regenerated the schema from it. Three golden fixtures test compiler-specific attributes on purpose. Each of them now turns the option on, so its output does not change. A project that wants those attributes documented has to turn the option on.
Testing
The golden fixture for the option already runs with it off, which is now the default. The three fixtures above keep the opt-in path under test.
Documentation
I updated the option description in the configuration reference. No other page mentions the default.