Merged
Conversation
- make sure minimum is now Java 17
* class is a reserved keyword in java code which leads to a compile error when copy pasting this code example
This change enhances the numberFormat helper to support both 'format' and 'locale' as named parameters (via options hash), in addition to their existing support as positional arguments. The implementation now follows the same flexible pattern used by the dateFormat helper. The Javadoc has been updated accordingly. Includes tests for: - format as a named parameter - locale as a named parameter - mixed positional + named usage - support for locale strings like 'pt-BR'
- makes build fail on 21
sumerjabri
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge latest from upstream
Merge https://github.com/campeis/handlebars.java/tree/update_handlebars_js_to_4_7_9. See jknack/handlebars.java#1178
https://github.com/craftersoftware/craftercms/issues/1228