Add first-class per-call metadata for observability (#807) - #825
Closed
goianiense wants to merge 1 commit into
Closed
Add first-class per-call metadata for observability (#807)#825goianiense wants to merge 1 commit into
goianiense wants to merge 1 commit into
Conversation
Introduce RubyLLM::Metadata and Chat#with_metadata so apps can attach namespace/tags that flow into instrumentation payloads without monkey-patching. One-shot APIs accept a metadata: keyword; Agent and ActiveRecord chat models delegate the fluent API.
Owner
|
Thanks for the PR. We took the core observability idea, but not this API shape. Main now supports simple metadata on the one-shot APIs and includes it directly in the instrumentation payload. That landed in 1bc6fc0. The smaller shape intentionally avoids a RubyLLM::Metadata value object and does not add chat, agent, or ActiveRecord metadata APIs in this PR's form. Provider request customization stays under params. Closing this PR as superseded. The linked issue remains open for the separate question of whether chat and tool-call instrumentation should get a minimal metadata API too. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RubyLLM::Metadata(namespace+tags) andChat#with_metadatafor opt-in caller attribution on instrumentation eventsmetadatainchat.ruby_llmandtool_call.ruby_llmpayloads; one-shot APIs (embed,paint,moderate,speak,transcribe) acceptmetadata:Agentand ActiveRecordChatMethods; documents usage in the instrumentation guideCloses #807
Test plan
bundle exec rspec spec/ruby_llm/instrumentation_spec.rbpayload[:metadata]without reaching into chat ivarswith_metadatachaining merges tags and replaces namespace when set