Update cache to ignore values over 250 characters (D1118)#596
Update cache to ignore values over 250 characters (D1118)#596
Conversation
78a6489 to
cf79966
Compare
What do you mean by "update insert the value"? |
Fixed |
abeverley
left a comment
There was a problem hiding this comment.
Thanks Dave, good work on getting the test added. A bit more to do though I'm afraid...
- Fix incorrect return on calc cache code - Add unit test to ensure correct write operation
f891ebf to
ecff432
Compare
|
Thanks Dave, this is great. Just 2 very minor things before merging: add a brief comment to the new test explaining what it is testing (I know I haven't always done this, and I've seen the problems it creates!); plus, remove the Data::Dumper from the included libraries. |
This code checks the
%valueshash and does not insert the value into the cache should there be any values over 250 characters inserted into the field.