Skip to content

Update cache to ignore values over 250 characters (D1118)#596

Merged
abeverley merged 5 commits intoctrlo:devfrom
droberts-ctrlo:calc-cache-change
Apr 17, 2026
Merged

Update cache to ignore values over 250 characters (D1118)#596
abeverley merged 5 commits intoctrlo:devfrom
droberts-ctrlo:calc-cache-change

Conversation

@droberts-ctrlo
Copy link
Copy Markdown
Contributor

@droberts-ctrlo droberts-ctrlo commented Jan 12, 2026

This code checks the %values hash and does not insert the value into the cache should there be any values over 250 characters inserted into the field.

@droberts-ctrlo droberts-ctrlo changed the title Update cache to ignore values over 250 characters Update cache to ignore values over 250 characters (D1118) Jan 12, 2026
@pawelwlod
Copy link
Copy Markdown

This code checks the %values hash and does not update insert the value into the cache should there be any values over 250 characters inserted into the field.

What do you mean by "update insert the value"?

@droberts-ctrlo
Copy link
Copy Markdown
Contributor Author

This code checks the %values hash and does not update insert the value into the cache should there be any values over 250 characters inserted into the field.

What do you mean by "update insert the value"?

Fixed

Comment thread t/007_code_cache.t Outdated
Copy link
Copy Markdown
Contributor

@abeverley abeverley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave, good work on getting the test added. A bit more to do though I'm afraid...

Comment thread lib/GADS/Datum/Code.pm Outdated
Comment thread t/007_code_cache.t
Comment thread t/007_code_cache.t Outdated
Comment thread t/007_code_cache.t Outdated
Comment thread t/007_code_cache.t Outdated
- Fix incorrect return on calc cache code
- Add unit test to ensure correct write operation
@abeverley
Copy link
Copy Markdown
Contributor

Thanks Dave, this is great. Just 2 very minor things before merging: add a brief comment to the new test explaining what it is testing (I know I haven't always done this, and I've seen the problems it creates!); plus, remove the Data::Dumper from the included libraries.

@abeverley abeverley merged commit b6ec540 into ctrlo:dev Apr 17, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants