Version Packages - #1266
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@cube-dev/ui-kit@0.149.2
Patch Changes
#1261
ce4664acThanks @solarrust! -DialogTrigger'smobileTypenow defaults to the same value astypeinstead of silently convertingtype="popover"to a full-screen modal under the 700px breakpoint. That auto-conversion was never an intentional per-consumer choice —FilterPickerandPickerboth inherited it by omission, giving them an unrequested full-screen modal (with a close button) on narrow viewports like the Excel/Google Sheets add-in task pane. Consumers that want a different mobile presentation (e.g.DatePicker'smobileType="tray") are unaffected, since they already set it explicitly.FilterPickeradditionally no longer shows a close button in its popover at all (isDismissable={false}on its own Dialog) — it read as a duplicate of the existing "Clear" action in the header.Note
Low Risk
Release bookkeeping only in this PR; the underlying UI behavior change is a targeted mobile/dialog default fix with low blast radius for consumers that already set
mobileTypeexplicitly.Overview
This is a Changesets version-packages merge: it bumps
@cube-dev/ui-kitfrom 0.149.1 to 0.149.2, updates CHANGELOG.md, and removes the consumed changeset file. There are no runtime source edits in the diff—only release metadata.The 0.149.2 patch documents behavior already landed in #1261:
DialogTriggernow defaultsmobileTypeto matchtypeinstead of forcingtype="popover"into a full-screen modal below 700px (fixing unintended mobile modals forFilterPicker/Pickerin narrow panes).FilterPickeralso setsisDismissable={false}on its dialog so the popover no longer shows a redundant close button beside Clear.Reviewed by Cursor Bugbot for commit 61c3eba. Bugbot is set up for automated code reviews on this repo. Configure here.