CM-67459: Enrich session context payload#477
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@claude review once |
There was a problem hiding this comment.
An organization admin can view or raise the cap at claude.ai/admin-settings/claude-code. The cap resets at the start of the next billing period.
Once the cap resets or is raised, comment @claude review on this pull request to trigger a review.
| return _get_macos_serial_number() | ||
| if system == 'Windows': | ||
| return _run( | ||
| ['powershell', '-NoProfile', '-Command', '(Get-CimInstance -ClassName Win32_BIOS).SerialNumber'] |
There was a problem hiding this comment.
i'm not sure but maybe we should avoid subprocess for this? (powershell takes time to spawn) (we can probably get it through python libraries)
| # platform_name mapping | ||
|
|
||
|
|
||
| def test_get_platform_name_maps_known_systems(mocker: MockerFixture) -> None: |
There was a problem hiding this comment.
all of these tests are mocked and meaningless
|
|
||
| def get_last_login_user() -> Optional[str]: | ||
| try: | ||
| return getpass.getuser() or None |
There was a problem hiding this comment.
did you check this is not returning root from hooks?
3 participants
No description provided.