Add -s flag to build_app.sh to use system jsoncpp and libsecret#1308
Merged
danrmiller merged 3 commits intostagingfrom Apr 30, 2026
Merged
Add -s flag to build_app.sh to use system jsoncpp and libsecret#1308danrmiller merged 3 commits intostagingfrom
danrmiller merged 3 commits intostagingfrom
Conversation
danrmiller
force-pushed
the
use_system_secure_storage_deps
branch
2 times, most recently
from
27ba753 to
91db545
Compare
danrmiller
force-pushed
the
use_system_secure_storage_deps
branch
from
91db545 to
cb69ea2
Compare
Add back in secure storage dependencies until docker branch is merged
danrmiller
force-pushed
the
use_system_secure_storage_deps
branch
from
cb69ea2 to
7147de2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1308 +/- ##
========================================
Coverage 4.87% 4.87%
========================================
Files 1050 1050
Lines 107031 107031
========================================
Hits 5217 5217
Misses 101814 101814 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sneurlax
previously approved these changes
Apr 29, 2026
Member
sneurlax
left a comment
sneurlax
left a comment
There was a problem hiding this comment.
LGTM and I tested this and it apparently works both ways. But I didn't test in a fresh env which might fail with -s
Collaborator
Author
We probably want it to fail if the libs aren't installed and -s is used. We could try to detect them but I think this keeps everything in line with existing expectations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.