Skip to content

Use cygpath on Windows CI, fall back to wslpath for WSL #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danrmiller wants to merge 1 commit into
base: staging
Choose a base branch
from
+12 −3
Open

Use cygpath on Windows CI, fall back to wslpath for WSL #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/app_config/shared/asset_generators.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ pushd "${APP_PROJECT_ROOT_DIR}"
YAML_FILE="${APP_PROJECT_ROOT_DIR}/scripts/app_config/platforms/${APP_BUILD_PLATFORM}/flutter_launcher_icons.yaml"
if [[ "${APP_BUILD_PLATFORM}" = 'windows' ]]; then
cmd.exe /c flutter pub get
WIN_PATH_VERSION=$(wslpath -w ${YAML_FILE})
if command -v cygpath >/dev/null 2>&1; then
WIN_PATH_VERSION=$(cygpath -w "${YAML_FILE}")
else
WIN_PATH_VERSION=$(wslpath -w "${YAML_FILE}")
fi
cmd.exe /c dart run flutter_launcher_icons -f "${WIN_PATH_VERSION}"
# not needed in windows
# cmd.exe /c dart run flutter_native_splash:create
Expand Down
9 changes: 7 additions & 2 deletions scripts/app_config/shared/link_assets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,13 @@ for dirname in "default_themes" "icon" "lottie" "in_app_logo_icons" "svg"; do
rm -f "${ASSETS_DIR}/${dirname}"

if [[ "${APP_BUILD_PLATFORM}" = 'windows' ]]; then
LINK_SOURCE_DIR_WIN_PATH_VERSION=$(wslpath -w "${LINK_SOURCE_DIR}")
LINK_NAME_WIN_PATH_VERSION=$(wslpath -w "${ASSETS_DIR}")
if command -v cygpath >/dev/null 2>&1; then
LINK_SOURCE_DIR_WIN_PATH_VERSION=$(cygpath -w "${LINK_SOURCE_DIR}")
LINK_NAME_WIN_PATH_VERSION=$(cygpath -w "${ASSETS_DIR}")
else
LINK_SOURCE_DIR_WIN_PATH_VERSION=$(wslpath -w "${LINK_SOURCE_DIR}")
LINK_NAME_WIN_PATH_VERSION=$(wslpath -w "${ASSETS_DIR}")
fi
cmd.exe /c mklink /D "${LINK_NAME_WIN_PATH_VERSION}\\${dirname}" "${LINK_SOURCE_DIR_WIN_PATH_VERSION}"
else
ln -s "${LINK_SOURCE_DIR}" "${ASSETS_DIR}/${dirname}"
Expand Down
Loading