Drop the polyfill for the engine's findConfigDirs - #2
Draft
grouville wants to merge 1 commit into
Draft
Conversation
The engine now ships Workspace.findConfigDirs (dagger/dagger#13769): the same cwd-aware project discovery this module got from github.com/dagger/polyfill — same semantics, ported from the polyfill's own design and test matrix. Swap the call, drop the dependency, and require the engine release that ships it. This module was still pinned to v0.20.6 and used the legacy Workspace.path field, which the v1 view removed — so the version bump also ports the relative-path helper onto Workspace.cwd, the v1 spelling of the same value. The engineVersion bump and the dependency removal have to land together: the version gate is what keeps the engine's new changeset behavior scoped to migrated modules. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates this repo off
github.com/dagger/polyfill, onto the engine's own workspace APIs — part of dagger/dagger#13769 (tracking checklist there; engine PRs dagger/dagger#13854 and dagger/dagger#13855).Two call sites (
docker.dang,compose.dang):polyfill…findConfigDirs(...)becomesws.findConfigDirs(...). This module was also still pinned tov0.20.6and used the legacyWorkspace.pathfield, which the v1 view removed — the bump therefore also ports the relative-path helper ontoWorkspace.cwd, the v1 spelling of the same value.Verified locally against a dev engine built from the two engine PRs by installing the migrated module into a scratch workspace:
docker projectsdiscovers the expected projects, cwd-relative. Two notes, both reproduced on unmodifiedmainagainst the same dev engine (pre-existing, unrelated to this PR): the workspace's remoteproxymodule (https://-schemed source) fails to load on dev engines, and the pinned dang-sdk's generate check fails on it.CI stays red until the engine release that ships these APIs exists. The
engineVersionbump assumesv1.0.0-beta.10— adjust if the release numbers differently. The bump and the dependency removal must land together: the version gate is what scopes the engine's new changeset rooting to migrated modules.