correct some intent and shared hungarian tests hungarian intent property translations

[hammera]

Hy Boys,

In #557 issue @MartheGjelstad intent attribute tests related answer, I doed some cosmetic changes with tests/language/hu/shared.rs file and tests/languages/hu/intent.rs files related.
Previous, the „perpendicular to” string, the „testing of” string parts (normal and prefix type test), and the „forced” string parts are presents untranslated, because I not known previous this string parts are need translate inside the MathML expression the intent attribute part into the affected tests, not with any Rules/Languages/hu awailable rule files. :-):-)
Have two test with me need restore after the main branch merge happened, because have differences the april 24 branch state of the hu branch and the actual branch state with two tests related.
So, now only have 523 hungarian tests again.

In my local machine following commands ran successfull:

• cargo build,
• cargo test Languages::hu,
• cargo test --lib (navigation tests),
• cargo check.

Cargo clippy me drops following output:

warning: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ...32(*ch).unwrap(), *ch as u32);
     |                      ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unnecessary_cast
     = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: `mathcat` (lib) generated 1 warning (run `cargo clippy --fix --lib -p mathcat` to apply 1 suggestion)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s

Cargo test command drops me following result, I copyed only end of results:

failures:
    braille::Swedish::swedish::ex_6_15
    braille::Swedish::swedish::ex_6_16
    braille::Swedish::swedish::ex_6_19

test result: FAILED. 1422 passed; 3 failed; 31 ignored; 0 measured; 0 filtered out; finished in 6.22s

This result is equals the friday evening result, when the merge happened from the hu branch of the main branch.

Please merge this corrected tests into the github.com/daisy/mathcat repository hu branch, and after this merge, if this is possible please merge this change to the github.com/daisy/mathcat repo main branch too.

Thank you the very good cooperation,

Attila

[hammera]

Cargo clippy related online workflow check produce exit code 101 error.
The log file show following, this is I think not related the hungarian tests related fix with I committed this day.
If this is not the case, please tell me what can me need fixing the affected test Rust files and I will doing the proper fix.
The log file output:

    Checking env_logger v0.11.11
error: casting to the same type is unnecessary (`u32` -> `u32`)
    --> src/speech.rs:2828:147
     |
2828 | ... unicode tables", char::from_u32(*ch).unwrap(), *ch as u32);
     |                                                    ^^^^^^^^^^ help: try: `{ *ch }`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#unnecessary_cast
     = note: `-D clippy::unnecessary-cast` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`

error: could not compile `mathcat` (lib) due to 1 previous error
Error: Process completed with exit code 101.

Attila

[hammera]

I synced my feature branch with the main repository, now more Github online workflow checks passed.
Very interesting, but after syncing the main branch and merge two branches with an interactive rebase, cargo test command shows me a failure with hungarian intent test in intent_prob_x function, without the left and right expression. If I ran only the cargo test Languages::hu command, the hungarian tests passed (perhaps a phantom failure because logging turned on the intent_prob_x function)?
After I commented out the init_logger(); function call into the hungarian intent.rs file intent_prob_x function, entire cargo test command pass successfull after branch syncing, and of course the normal cargo test Languages::hu test command pass too, produce wanted result the language tests.

Attila

[hammera]

Now everithing looks fine, previous force-push operation not added with @NSoiffer june 29 doed clippy fix.
Now builds related online workflow checks are passed, the fuzzing related check require more time to run successfull (yesterday evening require about 45 minutes to ran).
So, following checks now ran successfull:

• clippy lint check,
• Rust build and test,
• Python related check,
• Rules directory zipping.
  Now still running the Fuzz / Build and fuzz (with MathML dict + corpus cache) online workflow check.

Attila

[hammera]

Very nice, now all online Github workflow checks are passed.

[hammera]

Don't surprise with force-push related, I doed only little cleanup my feature branch and squashed few commits during interactive rebase my feature branch. :-):-)
Progress status with optional hungarian unicode-full.yaml file translation revieving related work:
There are only 1784 untranslated messages left in the Hungarian unicode-full.yaml file. I still need to review these and mark the correct versions as translated messages. To avoid data loss and to keep the Hungarian development branch always in sync, I will upload the current Hungarian unicode-full.yaml file to the Hungarian development branch every evening.
I am trying to hurry up with this remaining translation task as much as possible so that the of this optional unicode-full.yaml file complete translation can be included in the final MathCAT version.

[hammera]

Boys, change anything in Rust stable version?
Previous days cargo clippy check are not failed, but when I update with rustup update command my Rust environment the latest stable update, cargo clippy command doesn't ran too my local machine, similar with online Github workflow related clippy check.
Into the online log I seeing following:

    Checking linked-hash-map v0.5.6
error: redundant reference in `format!` argument
  --> build.rs:47:98
   |
47 | ...                   format!("build.rs couldn't create {:?}: {}", &zip_name, e))),
   |                                                                    ^^^^^^^^^ help: remove the redundant `&`: `zip_name`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting
   = note: `-D clippy::useless-borrows-in-formatting` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::useless_borrows_in_formatting)]`

error: redundant reference in `println!` argument
   --> build.rs:163:74
    |
163 |             println!("cargo::warning=couldn't change to directory '{}'", &out_dir.display());
    |                                                                          ^^^^^^^^^^^^^^^^^^ help: remove the redundant `&`: `out_dir.display()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting

error: redundant reference in `panic!` argument
   --> build.rs:182:67
    |
182 |             Err(e) => panic!("build.rs couldn't create {:?}: {}", &archive_path.to_str(), e),
    |                                                                   ^^^^^^^^^^^^^^^^^^^^^^ help: remove the redundant `&`: `archive_path.to_str()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting

error: could not compile `mathcat` (build script) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

I ran cargo clippy --fix --lib -p mathcat -- command, and cargo clippy --fix --lib -p mathcat -- --no-deps command.
I attaching the patch, but temporary committed this change too.
fix_clippy.patch

After Rust update and clippy suggested fixes, again my local system ran correct with cargo clippy, cargo build, cargo test, cargo check commands.

Now, into the unicode-full.yaml file remaining only with 686 untranslated messages.

Attila

[hammera]

Very fine, Rust Clippy lint check related online workflow now ran successfull again.

[hammera]

Very nice, final all other Github online checks are passed again.

[hammera]

@NSoiffer, I wanted syncing hu branc to the main branch, because I am see you doed more changes.
Now, in unicode-full.yaml remaining only 380 untranslated messages.
I see now more conflicted files, but my hu branch the tests ran successfull (cargo clippy, cargo test, etc).
In translation audit, I see following part with nunicode-full.yaml file:

⚠ unicode-full.yaml
  en: 2714 rules  →  hu: 2754 rules

What rules are removed from the en rules in unicode-full.yaml file?
Can you have possibility help resolve the merge conflicts in this PR? Now me not have this weekend more time looking this conflicts and analyze what changes produce conflicting results.
Next week I would like finalize unicode-full.yaml translation related remaining work, but would I like clean syncing the hu branch to the main branch before begin working again (lot of changes happened in main branch yesterday and previous day with I would like merge to the hu branch). :-):-)

Attila

[hammera]

@NSoiffer, fortunatelly I doed successfull the merge conflicts cleanup after morning I doed the rebase the hu branch to the upstream main branch.
Again equals the rule numbers both english and hungarian unicode-full.yaml and unicode.yaml files, only remaining 360 untranslated messages into the hungarian unicode-full.yaml file.
This untranslated messages related work I begin doing monday, but me need an one day rest in sunday. After this little work is ready, we clean have possibility to merge this PR first to the upstream Daisy MathCAT repo hu branch, and after this merge happens, of course the Github.com/daisy/mathCAT repo upstream main branch to the hungarian MathCAT speak translation is entire full ready.

Attila

[hammera]

Don't surprise, I doed only a main branch syncing and rebase (because happens changes into the english shared default.yaml file with two elements related).

Attila

[NSoiffer]

I resolved all the conflicts by accepting "incoming".

I removed the rules for a and A as they are the same as the generic letter tests (I extended the range to include A).

[NSoiffer]

The following differ between unicode.yaml and unicode-full.yaml:

Char	Code	unicode.yaml	unicode-full.yaml
‴	U+2034	hármas prím	hármas ikerprím
∀	U+2200	minden	mindenki számára
∗	U+2217	csillag operátortimes	csillag operátor
∷	U+2237	arány	mint
≦	U+2266	kisebb, mint egyenlő	kisebb az egyenlőségjel fölött
≧	U+2267	nagyobb, mint az egyenlő	nagyobb, mint egyenlő

unicode.yaml takes precedence, but there should only be one definition. I don't know which is correct. Please fix this up and do a PR.

Note: I've done some fixes to the 'hu' branch, so you should pull from that before making your changes.