Repository navigation
[WIP] Support dead letter topic in the subscribeToEvents api - #1615
Closed
HusseinYasser wants to merge 2 commits into
Closed
HusseinYasser wants to merge 2 commits into
HusseinYasser wants to merge 2 commits into
Conversation
…th dead letter topic Signed-off-by: HusseinYasser <husseinyasser388@gmail.com>
Signed-off-by: HusseinYasser <husseinyasser388@gmail.com>
HusseinYasser
commented
Jan 7, 2026
|
|
||
| try { | ||
| // Try to send RETRY acknowledgment | ||
| // TODO: push the event to the dead letter topic in case of processing errors |
Author
There was a problem hiding this comment.
Do we need to publish the events to the deadLetter topic on the sdk level?
or is it already implemented on the dapr daemon level once we build Drop Ack in the request stream ?
Contributor
|
Hi @HusseinYasser 👋 I'm doing a clean-up across all the Dapr repos to get things better organized, and as part of that I'm closing PRs that have had no activity in the last 6 months, like this one. If you don't agree, or you'd still like to get this in, please reopen it (or leave a comment here if you can't reopen it) and we'll take a look and prioritize it. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th dead letter topic
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: