fix: pin Netty to the gRPC-supported version in Spring modules#1793
Merged
javier-aliaga merged 1 commit intoJul 22, 2026
Merged
Conversation
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1793 +/- ##
=========================================
Coverage 76.85% 76.85%
Complexity 2300 2300
=========================================
Files 244 244
Lines 7145 7145
Branches 748 748
=========================================
Hits 5491 5491
Misses 1288 1288
Partials 366 366 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
siri-varma
reviewed
Jul 20, 2026
siri-varma
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Spring Boot 4 migration (#1772) has the Dapr Spring modules import the Spring Boot 4 BOM, which manages Netty 4.2.x. The SDK uses the non-shaded
grpc-netty(1.79.0), and per gRPC's compatibility matrix gRPC 1.79 targets Netty 4.1.x — no gRPC release supports Netty 4.2.x. Inside these modulesgrpc-nettyis acompile-scope transitive (viadapr-sdk), so it was resolving onto an unsupported Netty line.The concrete impact is on the SDK's own reactor: it was building and — more importantly — running its Spring integration tests and examples against a Netty version gRPC does not support (
sdk-tests/spring-boot-sdk-testsexercise real gRPC over a Testcontainersdaprd). In other words, "CI green" was validating gRPC on Netty 4.2.x, an untested combination that can fail withNoSuchMethodError/NoClassDefFoundError.Scope note: downstream apps that import
dapr-spring-bomare already protected — it pins Netty4.1.132transitively viadapr-sdk-bom. This change does not alter that; it aligns the SDK's own builds, tests, and examples with the same supported Netty version the core modules already use. The rootpom.xmlpinsnetty-bom4.1.132, but the Spring modules override it by importing the Spring Boot BOM in their owndependencyManagement, so the pin never reached them.Switching to
grpc-netty-shadedis not an option — it was deliberately removed in #1543 because shaded Netty breaks native compilation (Quarkus / Spring Native), prevents patching Netty CVEs, and increases memory usage.Fix
Import
netty-bom(${netty.version}=4.1.132) beforespring-boot-dependenciesin the gRPC-reachable Spring modules, so Maven's first-declared-wins rule keeps Netty on the gRPC-supported 4.1.x line:dapr-spring-boot-autoconfiguredapr-spring-datadapr-spring-boot-startersdk-testsspring-boot-examplesspring-boot-sdk-testsdapr-spring-boot-starter-testpulls no Netty transitively, so it is intentionally left unpinned.Verification
Resolved
io.netty:netty-commonviadependency:treein each affected module — all now resolve4.1.132.Final(previously4.2.12.Final), matching the version already used by the core SDK.Checklist