Repository navigation
Conversation
Follow-up to the review on darnitdevorg#575. - The check reads --output json: it fails on any control with error class "evaluation" and requires OSPS-QA-05.01 to pass. darnitdevorg#582 reworded the message the old grep matched. - A dist/ with more than one wheel of a package is refused instead of silently picking the first one. Checked: with "packaging" removed from darnit-core's metadata the run fails naming OSPS-QA-05.01 and OSPS-QA-05.02. Assisted-by: Claude:claude-fable-5-1 Signed-off-by: Marc-cn <130138935+Marc-cn@users.noreply.github.com>
mlieberman85
approved these changes
Oct 16, 2026
mlieberman85
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this does what #575's review asked. I checked it: blocking packaging fails with QA-05.01/05.02 as described, and the normal run passes. Point 3 (importing every darnit* module) would still be useful for the proposed F4 rule, since gittuf/reproducibility are only imported through registration; a follow-up is fine. Optional: print each broken control's error.cause next to its id so a CI failure explains itself.
Drafted with Claude Code; reviewed and posted by me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the review on #575, points 1 and 2:
--output json. The check fails on any control with error classevaluation, and requiresOSPS-QA-05.01to pass. The old grep matched "not installed", which fix: report the real cause when cel-python or tree-sitter fails to import #582 reworded.dist/holding more than one wheel of a package is refused, naming the files, instead of silently picking the first.Point 3 (importing every
darnit*module in the full install) is not done here.Checked by hand: with
Requires-Dist: packagingremoved from the darnit-core wheel's metadata, the minimal run fails with "controls that could not be evaluated: OSPS-QA-05.01, OSPS-QA-05.02". A duplicatedarnit_core-0.0.9wheel is refused. shellcheck is clean.Type of Change
Framework Changes Checklist
docs/architecture/framework-design.md) if behavior changed (CI only)uv run python scripts/validate_sync.py --verboseand it passes (not run: CI script only)Testing
AI assistance
Claude Fable 5.1 wrote the changes and drafted this description. I ran every command and checked the results myself. The commit carries an
Assisted-by: Claude:claude-fable-5-1trailer.