Skip to content

fix(dashproof-lab): make success/error notices and toasts readable in light theme#76

Merged
thephez merged 1 commit intomainfrom
style/dashproof-notification
May 6, 2026
Merged

fix(dashproof-lab): make success/error notices and toasts readable in light theme#76
thephez merged 1 commit intomainfrom
style/dashproof-notification

Conversation

@thephez
Copy link
Copy Markdown
Collaborator

@thephez thephez commented May 6, 2026

Summary

  • OperationResultNotice success/error tones used hardcoded dark oklch values, leaving dark text on a dark panel in light mode. Swapped them for --color-success-* / --color-error-* CSS variables defined per-theme in globals.css.
  • Sonner <Toaster /> was rendering with its default theme regardless of the app theme. Now passes the active theme from useTheme() and enables richColors so success/error toasts use proper contrast in both modes.
  • Tightened useTheme to use useSyncExternalStore<Theme> so the returned value stays narrowed to "light" | "dark" (needed for the new Toaster prop).

… light theme

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@thephez has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 29 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5bcead3f-ddeb-42c5-a0f7-3e4a6b8c58ee

📥 Commits

Reviewing files that changed from the base of the PR and between fb19a9c and b9e0bd1.

📒 Files selected for processing (4)
  • example-apps/dashproof-lab/src/App.tsx
  • example-apps/dashproof-lab/src/components/OperationResultNotice.tsx
  • example-apps/dashproof-lab/src/hooks/useTheme.ts
  • example-apps/dashproof-lab/src/styles/globals.css
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch style/dashproof-notification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thephez thephez merged commit 8f0fb0a into main May 6, 2026
3 checks passed
@thephez thephez deleted the style/dashproof-notification branch May 6, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant