BUG: testing: fix check_shape=False with broadcasting#735
Merged
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
prady0t
changed the title
prady0t
commented
May 13, 2026
lucascolley
reviewed
May 13, 2026
lucascolley
requested changes
May 13, 2026
lucascolley
changed the title
check_shape=False with broadcasting
Contributor
Author
|
Ah! My bad. |
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
lucascolley
reviewed
May 14, 2026
lucascolley
reviewed
May 14, 2026
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
lucascolley
approved these changes
May 14, 2026
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
LGTM now if CI is happy, thanks Pradyot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #724